feat(shell): give analysts their own sidebar and command palette by Makisuo · Pull Request #2550 · MapleTechLabs/maple

Makisuo · 2026-11-12T23:59:26Z

Fifth layer of the Analyst role, on top of #2549. Analysts get a sidebar and command palette built around what they come for.

What changed

Sidebar. An analyst sees Overview, then Reliability (Incidents with Inbox, Uptime and SLOs; Errors; Status pages) and Product (Web analytics, Users, Replays, Dashboards, Releases, Cost). Flagged rows still follow the org's rollouts.
Left out for them: Services, Infrastructure, the explorers, alert rules and routing, Review & CI, Security, and the Sources and Settings rows. Their account stays in the user menu.
Top bar. No Connect button: an analyst sets up no telemetry source.
Command palette. Lists the same pages, plus dashboards and the app actions. Services, "Connect " and the setup pages do not show up in search.
Links still open. Nothing is redirected. A trace or log link an engineer shares opens, and the API refuses any change outside dashboards (the layers below).
Lab. /lab/shell has a Viewer toggle that draws the shell for an analyst.

Self-hosted has no analysts, so its shell is unchanged.

Screenshots

Member and above (unchanged)	Analyst

Incidents opens to its three pages:

Verified

apps/web: the shell tests, 128 passed. Cases: the analyst nav links to exactly its pages and to no setup or explorer page, rollout flags add Status pages, Releases and Cost, an uptime page marks only Incidents, the palette finds an analyst's pages and dashboards but not Traces, services, Connect entries or Settings, and Enter opens the page they see highlighted.
@maple/web typecheck, the CI lint config on the changed files, and the UI class pattern check.
/lab/shell driven in a headless browser for the screenshots.

An observer follows the product without operating it, so the shell shows them the pages that answer whether it works and how it is doing: incidents with uptime and SLOs, errors, status pages, web analytics, users, replays, dashboards, releases and cost. The explorers, infrastructure, alert setup, review, security, Sources, Settings and the Connect button are left out. The command palette lists the same pages plus dashboards and the app actions. Other pages still open from a link: nothing is redirected, and the API refuses any change. The shell lab gains a viewer toggle to draw the sidebar for an observer.

coderabbitai · 2026-11-12T23:59:35Z

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 17 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: defaults
Review profile: CHILL
Plan: Advanced
Run ID: 4c3f7b4f-56b7-4cd6-8441-49b17aad3620

Commits

Reviewing files that changed from the base of the PR and between 6a35f17 and 2cc964e.

Files selected for processing: 15

apps/web/src/lab/shell-frame.ts
apps/web/src/lab/shell-states-lab.scene.test.ts
apps/web/src/lab/shell-states-lab.ts
apps/web/src/shell/model.ts
apps/web/src/shell/nav.test.ts
apps/web/src/shell/nav.ts
apps/web/src/shell/palette/entries.ts
apps/web/src/shell/palette/global-shortcuts.test.ts
apps/web/src/shell/palette/model.ts
apps/web/src/shell/palette/palette.test.ts
apps/web/src/shell/palette/update.ts
apps/web/src/shell/palette/view.ts
apps/web/src/shell/view-nav.ts
apps/web/src/shell/view-sidebar.ts
apps/web/src/shell/view.ts

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

maple-review-bot

1 inline note from Maple's review. The score and summary are in the review comment above.

An observer's sidebar calls the alerts inbox Incidents, but the palette built its rows from the full nav, so it listed that page as Alerts and a search for incidents found nothing. Their entries now carry the observer nav's titles; the ids are unchanged, so a pick resolves the same way.

maple-review-bot

1 inline note from Maple's review. The score and summary are in the review comment above.

…button

# Conflicts: # packages/domain/src/policy/roles.ts

maple-review-bot · 2026-11-13T11:36:33Z

Maple review

🟢 Confidence 10/10 · safe to merge. Audience is read from the shared Policy.isAnalyst on every surface, and the lab fixture is the only thing that lags.
_{1 note · tests covered · risk medium}

Gives analysts their own sidebar, palette and top bar: navGroups takes an audience, the palette filters and retitles to the analyst's pages, and Sources, Settings and Connect are dropped for them. Scoped and safe to merge.

navGroups(flags, audience) returns analystNavGroups for analysts
entriesFor drops setup, explorer and service entries and retitles Incidents
shellAudience reads the Clerk role through Policy.isAnalyst
Sidebar footer rows and the top bar Connect hide for analysts

Findings

🔵 Note · F3 · The lab's clerk fixture reaches frameView but not the sheet or menu layers

correctness · apps/web/src/lab/shell-frame.ts:34

The new input is only handed to frameView; the sheet and menu layers below still get { currentPath } alone, so at a phone width /lab/shell with Viewer on Analyst opens the mobile nav through shellNavGroups(null) and draws the operator sidebar with Sources and Settings.

Pass `clerk: frame.clerk` in both the sheet's and the menu layer's `viewInputs`, so every part of the lab shell draws the viewer the toggle sets.

🤖 Prompt to fix this finding with an AI agent

Findings from an automated review of commit 2cc964e316f8902ecefdf2f760c27d601db480ad. Verify each one against the current code before changing anything, fix only those that still apply, and keep each fix to the lines it names.

---

F3 · Note · correctness · apps/web/src/lab/shell-frame.ts:34
The lab's `clerk` fixture reaches `frameView` but not the sheet or menu layers
The new input is only handed to `frameView`; the sheet and menu layers below still get `{ currentPath }` alone, so at a phone width `/lab/shell` with Viewer on Analyst opens the mobile nav through `shellNavGroups(null)` and draws the operator sidebar with Sources and Settings.
Suggested fix: Pass `clerk: frame.clerk` in both the sheet's and the menu layer's `viewInputs`, so every part of the lab shell draws the viewer the toggle sets.

_{2cc964e · What was checked, coverage and telemetry details are on the Maple / review check. Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.}

This comment has been minimized.

Sign in to view

maple-review-bot Bot reviewed Nov 13, 2026

View reviewed changes

Comment thread apps/web/src/shell/palette/entries.ts Resolved

Makisuo mentioned this pull request Nov 13, 2026

feat(web): show analysts no control the API refuses them #2552

Merged

This comment has been minimized.

Sign in to view

maple-review-bot Bot reviewed Nov 13, 2026

View reviewed changes

Comment thread apps/web/src/shell/view-sidebar.ts Resolved

test(shell): pin the observer shell's missing setup rows and Connect …

5f07072

…button

This comment has been minimized.

Sign in to view

Makisuo added 5 commits November 13, 2026 12:12

refactor: rename the observer role to analyst

7bd831b

Merge branch 'observer/members' into observer/shell

bd3b9e9

# Conflicts: # packages/domain/src/policy/roles.ts

Merge branch 'observer/members' into observer/shell

1cd63cf

refactor(shell): read the analyst audience through Policy.isAnalyst

9f44d69

Merge branch 'observer/members' into observer/shell

2cc964e

Makisuo changed the title ~~feat(shell): give observers their own sidebar and command palette~~ feat(shell): give analysts their own sidebar and command palette Nov 13, 2026

Makisuo added this pull request to stack #2556 November 13, 2026 12:45

Makisuo merged commit b8cc358 into main Nov 13, 2026
63 of 75 checks passed

Makisuo deleted the observer/shell branch November 13, 2026 12:56

Navigation Menu

Repository navigation

feat(shell): give analysts their own sidebar and command palette - #2550

feat(shell): give analysts their own sidebar and command palette#2550
Makisuo merged 8 commits into
observer/membersfrom
observer/shell

Makisuo commented Nov 12, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Nov 12, 2026 •

edited

Loading

Review limit reached

Uh oh!

This comment has been minimized.

maple-review-bot Bot left a comment

Uh oh!

Uh oh!

This comment has been minimized.

maple-review-bot Bot left a comment

Uh oh!

Uh oh!

This comment has been minimized.

maple-review-bot Bot commented Nov 13, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

Makisuo commented Nov 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changed

Screenshots

Verified

Next

Uh oh!

coderabbitai Bot commented Nov 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review limit reached

Uh oh!

This comment has been minimized.

maple-review-bot Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This comment has been minimized.

maple-review-bot Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This comment has been minimized.

maple-review-bot Bot commented Nov 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Maple review

Findings

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Makisuo commented Nov 12, 2026 •

edited

Loading

coderabbitai Bot commented Nov 12, 2026 •

edited

Loading

maple-review-bot Bot commented Nov 13, 2026 •

edited

Loading