Skip to content

perf(native): smoother scrolling on Rune, less work per frame, code block line breaks - #480

Merged
Makisuo merged 7 commits into
mainfrom
t3/improve-rune-performance
Nov 12, 2026
Merged

Makisuo merged 7 commits into
mainfrom
t3/improve-rune-performance

test(native): the sidebar menu check hovers a channel row again

8544251
Select commit
Loading
Failed to load commit list.
Maple Review Bot / Maple / review succeeded Nov 12, 2026 in 25s

Confidence 9/10 · No issues found

🟢 Confidence 9/10 · safe to merge. The delta is one constant in a bench script; the remaining gap is the untested kept-row path in containerRows (earlier finding F1).
1 note · tests partial −1 · risk medium

Only the bench harness changed since the last review: the sidebar channel-menu check now hovers a channel row at [200, 270] so the row's dots trigger is showing when clickLabel presses it. No new defects in that hunk.

  • sidebar channel menu check hovers [200, 270] instead of [200, 220], over a channel row

Still open from earlier reviews

What was checked
  • The new hover point is used by all three closers; the trigger closer still replays only clickLabel (run.ts:189)
  • Rune is pinned to c3536c2 in both host Cargo.toml files, so Tx::scroll_by is present
  • No test calls MessageList.view; the kept-row branch added at message-list.ts:837 stays covered only through keptIndexes

8544251 · Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.