Skip to content

fix(native): HTML renders on iOS, tweet photos that fill their box - #477

Merged
Makisuo merged 4 commits into
mainfrom
fix/ios-html-renders-tweet-photos
Nov 12, 2026
Merged

fix(native): HTML renders on iOS, tweet photos that fill their box#477
Makisuo merged 4 commits into
mainfrom
fix/ios-html-renders-tweet-photos

fix(native): a fixed frame is not clipped by the list it sits in

4fccfb6
Select commit
Loading
Failed to load commit list.
Maple Review Bot / Maple / review succeeded Nov 12, 2026 in 59s

Confidence 10/10 · No issues found

🟢 Confidence 10/10 · safe to merge. The delta is four lines moving the portal clip reset ahead of the iframe branch, pinned by a test that puts the fixed frame in a scrolling list.
no findings · tests covered · risk medium

Moves the portal clip reset ahead of the iframe branch in walk, so a fixed HTML render inside a scrolling list is no longer clipped by it, and extends the layer test to cover that case. Safe to merge.

What was checked
  • own_clips now covers the iframe branch (frames.rs:60), so a fixed iframe carries no ancestor clips; a_fixed_frame_is_its_own_layer asserts clips is empty.
  • scrolls_x needs a non-wrapping flex row (layout.rs:708), so the new clip in walk never applies to a code block or table.
  • is_over compares the sticky's layer to the frame's (frames.rs:101), keeping a page's pinned date off a dialog's frame.

4fccfb6 · Reply "won't fix" to dismiss a finding, or mention @maple-review-bot to ask about one.

View more details on Maple Review Bot