Repository navigation
Point ios-sdk-core at the polygon hole union fix - #16
Merged
Merged
Conversation
ios-sdk-core ca81984 (MapConductor/ios-sdk-core#32): unionHoleRings merges touching or overlapping holes so their shared area is not filled back in. Also brings in the core changes merged since 8709b1a (overlay stacking order, clear strategy, geodesic fill, clear order).
ios-sdk-core ca81984 asks MarkerRenderingSupport for clearMarkers() (clear strategy, ios-sdk-core#30); the providers' develops already have it (merged), the gitlinks here did not. Without this the sample does not build (HereMapHost does not conform).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
なぜ
近い穴を結合するときに穴の面積が失われ、街区などが塗りつぶされていた不具合の修正が ios-sdk-core でマージ済みです:
何を変えたか
MarkerRenderingSupportがclearMarkers()を要求するようになっています(clear strategy, ios-sdk-core#30)。プロバイダ側の対応は各 develop にマージ済みですが、ここの gitlink が古いままで、core だけ進めるとサンプルがビルドできません(HereMapHost does not conform to protocol 'MarkerRenderingSupport')。検証
xcodebuild test(iPhone 17 Pro シミュレータ): 371 件、失敗 0。scripts/api-surface.sh check ios-sdk-core: ok(CI と同じ範囲)。確認できていないもの
scripts/api-surface.sh check(全モジュール)は、core 以外で落ちるものがあります。ArcGIS / Google / Mapbox / MapLibre / MapTiler / Mappls / icons は一時ディレクトリでのバイナリ取得(xcframework の Info.plist が無い)で、ios-geojson / ios-kml は型名の表記(UIKit.UIColor→UIKit::UIColor)の差分、heatmap / marker-clustering はベースライン未作成です。いずれもこの PR の変更(gitlink)による API の変化ではありません。