Skip to content

Interpolate the closing edge of polygons, geodesic or not #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wf9a5m75 merged 2 commits into from
Nov 8, 2026
Merged

Interpolate the closing edge of polygons, geodesic or not #12

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
29b278d
Interpolate the closing edge of geodesic polygons
wf9a5m75 Nov 8, 2026
265a72b
Densify the closing edge of non-geodesic polygons too
wf9a5m75 Nov 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions Sources/MapConductorForGoogleMaps/polygon/GoogleMapPolygonOverlayRenderer.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,9 @@ final class GoogleMapPolygonOverlayRenderer: AbstractPolygonOverlayRenderer<GMSP
mapView: GMSMapView
) -> GMSPath {
if !geodesic {
return makePath(Planar.createInterpolatePoints(points))
// geodesic=false も閉じる辺（末尾 → 先頭）を緯度経度で線形補間する（輪郭のポリラインと同じ線。
// 補間しないと閉じる辺だけメルカトルの直線になる）。
return makePath(densifyPolygonRing(points, geodesic: false))
}

let camera = mapView.camera
Expand All @@ -110,7 +112,9 @@ final class GoogleMapPolygonOverlayRenderer: AbstractPolygonOverlayRenderer<GMSP
return cached
}

let path = makePath(WGS84Geodesic.createInterpolatePoints(points, maxSegmentLength: maxSegmentLength))
// リングの閉じる辺（末尾 → 先頭）も大圏で補間する。隣り合う点の間だけを補間すると、閉じる辺が
// 直線の弦になり、塗りも輪郭（同じ GMSPolygon の stroke）もそこだけ直線になる。
let path = makePath(densifyPolygonRing(points, geodesic: true, maxSegmentLength: maxSegmentLength))
interpolationCache.put(key, path)
return path
}
Expand Down