Repository navigation
Draw marker labels into tiles as text, add vertical labels - #21
Merged
Merged
Conversation
…in-place changes from Markers(list) Same design as ios-sdk-core#23. - Tiles draw the body (dot, pin) as a shared bitmap and the label text after all bodies, so relabelling many markers no longer bakes a bitmap per text and position. Bodies are shared between icons differing only in label. A labelled marker wins its declutter cell; among labelled ones the world position decides, so neighbouring tiles agree. - ImageIcon gains the label options ColorDefaultIcon has, plus copy(). The pin and ImageIcon share one layout computation (IconLabelLayout). - labelWritingMode (CSS writing-mode: horizontal-tb, vertical-rl): vertical text stacks one glyph per em with OpenType 'vert', so the long-vowel mark turns and small kana sit as in vertical type. - Labelled icons record their overhang when created, and tiles search by it, so a label reaching in from the next tile is not cut right after a relabel. - OverlayCollector listens to states written straight into its flow. Since the switch to states reporting their own changes, Markers(list) wrote its list there without listening, and an in-place change to such a marker (an icon swapped to relabel a street tree) never reached the controller.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of the iOS tile-label work.
labelWritingMode("vertical-rl") onColorDefaultIcon/ImageIconfor vertical labels;ImageIcongains label params.OverlayCollectornow listens to states written straight into its flow.Markers(list)wrote there without registering listeners, so in-place changes (e.g. an icon swapped to relabel) never reached the controller.New types are
@InternalMapConductorApi;api/android-sdk-core.apiupdated.Verified on Pixel 5a with the street-tree sample (MapLibre).