Repository navigation
Fix heatmap tiles west of the date line being dropped - #11
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
何が起きていたか
タイルを描く前に「データ範囲と重なるか」を調べて早めに打ち切る判定が、日付変更線の回り込みを見ていませんでした。
HeatmapTileBinnerは回り込みに対応しているのに、点が経度 179.9 付近にしかないと、西隣のタイルが空のまま返っていました。修正
Bounds.intersectsWrappedを足し、データ範囲を東西に 1 周ずらした位置とも比べます。react-sdk / android-sdk / ios-sdk の 3 つに同じ修正を出しています（react-heatmap#5）。テスト
BoundsWrapTestを追加しました。