Repository navigation
Report camera fov and apply paddings - #30
Merged
Merged
Conversation
The padding TODO is enabled: MapCameraPosition.paddings (dp) is passed to MapLibre as px on move, animate and the initial camera, and read back from the camera's padding. MapLibre then places the target at the padded-area center and solves the perspective itself. fov is 36.87, the MapLibre default (measured 36.9 on TB520FU in both orientations).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This provider now
MapCameraPosition.fovfor its engine, andMapCameraPosition.paddingson move / animate: the target lands at the centre of the padded area, and the camera read back reports the target with the same paddings.Depends on the core
feat/camera-paddingsPR (and, where noted, the provider's tilt fix PR).fov 36.87 (engine default, measured 36.9); paddings native (the commented-out TODOs are enabled; dp → px).
Commits