Repository navigation
Expect this library's own test package in ExampleInstrumentedTest - #16
Merged
Merged
Conversation
The template was copied from android-for-googlemaps and still expected com.mapconductor.googlemaps, so connectedAndroidTest always failed here. A library's instrumented tests run in its test APK, whose package is com.mapconductor.mapbox.test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
不具合
ExampleInstrumentedTest.useAppContextが常に失敗していた。原因
android-for-googlemaps からコピーしたテンプレートのままで、期待値が
com.mapconductor.googlemapsだった。ライブラリの計装テストはテスト用 APK の中で動くので、targetContext.packageNameはcom.mapconductor.mapbox.testになる。修正
期待値を
com.mapconductor.mapbox.testにした。1 行だけ。確認
MapConductor/tests の
./run.sh android -p mapbox -r mapbox=fix/example-instrumented-testでエミュレータ（mc_test）上のconnectedDebugAndroidTest: 4 件すべて成功（このテスト +MapboxGroundImageStyleChangeTestの 3 件）。develop では同じ実行で 3/4 だった。