Skip to content

Redraw a marker when its URL icon's image arrives #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wf9a5m75 merged 2 commits into from
Nov 6, 2026
Merged

Redraw a marker when its URL icon's image arrives #10

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e60a606
Redraw a marker when its URL icon's image arrives
wf9a5m75 Nov 6, 2026
300aeb0
Key the marker bitmap on iconRevision
wf9a5m75 Nov 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/main/java/com/mapconductor/longdo/LongdoAnnotations.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ import androidx.compose.ui.unit.IntSize
import androidx.compose.ui.unit.dp
import com.mapconductor.compose.info.InfoBubbleEntry
import com.mapconductor.core.marker.DefaultMarkerIcon
import com.mapconductor.core.marker.iconRevision
import com.mapconductor.core.marker.MarkerAnimation
import com.mapconductor.core.marker.MarkerState
import com.mapconductor.settings.Settings
Expand Down Expand Up @@ -67,7 +68,10 @@ internal fun LongdoMarkerOverlay(
onDragMove: (marker: MarkerState, devicePx: Offset) -> Unit = { _, _ -> },
) {
val density = LocalDensity.current.density
val bitmapIcon = remember(marker.icon) { (marker.icon ?: DefaultMarkerIcon()).toBitmapIcon() }
// URL の画像が届くと、アイコンは同じインスタンスのまま見た目だけ変わる。iconRevision が
// そのとき増えるので、それもキーにする（読むことで描き直しも起きる）。
val bitmapIcon =
remember(marker.icon, marker.iconRevision) { (marker.icon ?: DefaultMarkerIcon()).toBitmapIcon() }
val widthPx = bitmapIcon.size.width
val heightPx = bitmapIcon.size.height
val anchor = bitmapIcon.anchor
Expand Down
Loading