Repository navigation
Keep the map design across configuration changes - #22
Merged
Merged
Conversation
- The saver kept only the id and restored through Create(id), so Custom designs lost their attribution rules (and unknown ids became None). It now records whether the design was a preset. - The controller started with None and reported it on listener attach, and onMapLoaded reported a preset rebuilt from mapType. The state now seeds the controller and ignores a report with the same mapType, so a Custom design keeps its rules. - Device round-trip test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
designs lost their attribution rules (and unknown ids became None).
It now records whether the design was a preset.
and onMapLoaded reported a preset rebuilt from mapType. The state now
seeds the controller and ignores a report with the same mapType, so a
Custom design keeps its rules.
After a configuration change (screen rotation) the map state now keeps its design (id, style, attribution rules), uiSettings and camera paddings. Depends on android-sdk-core
MapViewStateBundle; merge order core → compose → providers. Verified by rotating a Lenovo tablet (HA26Z6JL); instrumented tests pass the saved Bundle through a real Parcel.