Repository navigation
Register the ground image controller again - #21
Merged
Merged
Conversation
The 1.3.0 release (f2cb298) moved overlay wiring onto registerOverlayController but left the ground image controller out, so GroundImage states never reached GoogleMapGroundImageController and nothing was drawn. Every other provider registers it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ground images have drawn nothing on Google Maps since 1.3.0.
The 1.3.0 release (f2cb298) moved overlay wiring onto
registerOverlayController, butGoogleMapViewControllerleftgroundImageControllerout.GroundImagestates therefore never reachedGoogleMapGroundImageController. It compiled cleanly and raised no error. Every other Android provider registers it (checked on develop: ArcGIS, HERE, Longdo, Mapbox, MapLibre, Mappls, MapTiler, OpenMobileMaps, TomTom, template).Fix:
registerOverlayController(groundImageController).Verified on TB520FU with the sample's Ground Image page. The bundled image now draws, and the "image from URL" switch (android-sdk-core#23) swaps in the URL image once it arrives.