Repository navigation
Report camera fov and apply paddings - #35
Merged
Merged
Conversation
3D: Camera holds the eye position. Under tilt the eye sits behind the point being looked at, so returning it as MapCameraPosition.position put the read-back 3 to 6 km short of the target at tilt 30 to 60. The read now returns the point at the screen center (screen-center unproject, falling back to eye + altitude * tan(pitch) along the heading). 2D: the read-back unprojected the inner MapView's size, which is twice the frame when the tilt emulation is on, so the center landed far away and the corners failed. It now uses the outer view's size. A tilt-only change also never reached the state because the Viewpoint did not change; it is emitted after the move now. The Viewpoint center was drawn half an attribution bar above the view center (25.5px on TB520FU), which read back 45m off; the center is now shifted so the position lands at the view center.
3D: SceneView has no insets, so paddings are emulated by moving the look-at point and undone on read. fov is read from SceneView: its fieldOfView is horizontal (29.3 portrait, 68.0 landscape on TB520FU), converted to vertical (45 in both, matching the measured 45.2-45.4). 2D: setViewInsets is not used because under the tilt emulation the inner MapView is twice the frame and rotated, so insets do not match on-screen padding. Paddings are emulated on the outer view with fov 0 (the tilt is drawn without perspective).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This provider now
MapCameraPosition.fovfor its engine, andMapCameraPosition.paddingson move / animate: the target lands at the centre of the padded area, and the camera read back reports the target with the same paddings.Depends on the core
feat/camera-paddingsPR (and, where noted, the provider's tilt fix PR).2D fov 0; 3D fov 45 (the SDK's horizontal fov converted to vertical); paddings emulated. Stacked on the
fix/arcgis-tilt-cameraPR.Commits