refactor: swap @inquirer/prompts umbrella for granular packages - #39
Merged
Merged
Conversation
Refresh the lockfile with pnpm update -r so ranges resolve past the published vulnerable ranges, then add two pnpm overrides for the deps whose parent ranges can't reach a patched version: tmp ^0.2.6 (external-editor pins ^0.0.33) and vite ^7.3.6 (vitepress 1.x locks vite 5 through plugin-vue). vitepress bumped to ^1.6.4. 30 alerts (40 advisories) -> 0. Docs site builds clean on vite 7.
Import only the five granular @InQuirer prompt packages the CLI uses, as optional peers. This drops external-editor/tmp (2016-era pkg with published advisories) from the tree, so the tmp pnpm override is no longer needed and is removed. The prompts used are unchanged; tests are re-mocked per package.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ManningWorks
marked this pull request as ready for review
September 19, 2026 11:52
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #38. Removes the
tmpoverride that PR added, by removing the reason it existed.Why
@inquirer/promptsis an umbrella that bundles ten prompts — includingeditor, which Projex never calls.editoris the only consumer ofexternal-editor, which pinstmp0.0.33 (2016-era, published advisories). No parent range reaches a patchedtmp, which is why #38 needed an override.The five prompts Projex actually uses are published granularly in the same scope, with identical call signatures, and none of them touch
external-editor/tmp.What
@inquirer/prompts→@inquirer/input+@inquirer/select+@inquirer/confirmas optional peers (matching the old umbrella contract)vi.mock('@inquirer/prompts', ...)→ per-packagevi.mock('@inquirer/input', () => ({ default: vi.fn() }))etc.tmpoverride deleted from root package.json (viteoverride stays — unrelated vitepress reason)Result
pnpm -r why tmpandpnpm -r why external-editorboth return empty — the vulnerable packages no longer enter the dependency tree at all.pnpm audit: no known vulnerabilities.Gate
Note:
@inquirer/searchand@inquirer/numberare declared as optional peers but imported nowhere — kept for parity with the umbrella's old surface; happy to drop them if you'd rather declare only what's used.