Add positionable (Proof of concept) - #4923
Draft
GniLudio wants to merge 85 commits into
Draft
Conversation
GniLudio
marked this pull request as draft
August 9, 2026 12:43
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+550
to
+558
| def scale( | ||
| self, | ||
| scale_factor: float, | ||
| *, | ||
| about_point: Point3DLike | None = None, | ||
| about_edge: Vector3DLike | None = None, | ||
| works_on_bounding_box: bool = False, | ||
| **kwargs: Any, | ||
| ) -> Self: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview: What does this pull request change?
Moves all positioning methods of the mobject class(es) into it's own class, which the mobject class(es) then inherit from.
List of positioning methods
align_on_borderalign_toapply_complex_functionapply_functionapply_function_to_positionapply_matrixapply_over_attr_arraysapply_points_functionapply_points_function_about_pointcenterdepthflipget_array_attrsget_bottomget_boundary_pointget_bounding_boxget_bounding_box_pointget_centerget_center_of_massget_continuous_bounding_box_pointget_coordget_cornerget_critical_pointget_depthget_edge_centerget_extremum_along_dimget_heightget_leftget_midpointget_nadirget_points_defining_boundaryget_rightget_topget_widthget_xget_yget_zget_zenithheightis_off_screenis_point_touchinglength_over_dimmatch_coordmatch_depthmatch_dim_sizematch_heightmatch_widthmatch_xmatch_ymatch_zmove_tonext_topfppoint_from_proportionpose_at_angleproportion_from_pointreduce_across_dimensionrescale_to_fitrotaterotate_about_originscalescale_to_fit_depthscale_to_fit_heightscale_to_fit_widthset_coordset_depthset_heightset_widthset_xset_yset_zshiftshift_onto_screenstretchstretch_about_pointstretch_to_fit_depthstretch_to_fit_heightstretch_to_fit_widthto_cornerto_edgewidthMotivation and Explanation: Why and how do your changes improve the library?
I think separating positioning methods from the mobject classes would improve the code quality due to the following reasons:
Further Information and Comments
Currently, this PR just moves the positioning methods into it's own class.
Here are additional changes that would sense:
kwargswith explicit parameters.(set|get)_(width|height|depth)methods and thewidth|height|depthproperties.get_cornerandget_edge_centerjust redirecting toget_critical_point.Positionablean abstract class.Reviewer Checklist