Fix default angled camera orientation in ThreeDScene#4704
Open
siddhu-pikachu wants to merge 1 commit intoManimCommunity:mainfrom
Open
Fix default angled camera orientation in ThreeDScene#4704siddhu-pikachu wants to merge 1 commit intoManimCommunity:mainfrom
siddhu-pikachu wants to merge 1 commit intoManimCommunity:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview: What does this pull request change?
Fixes
ThreeDScene.set_to_default_angled_camera_orientation()so it uses the stored default angled camera orientation kwargs, and adds a regression test for the method.Motivation and Explanation: Why and how do your changes improve the library?
ThreeDScene.__init__stores the defaults inself.default_angled_camera_orientation_kwargs, butset_to_default_angled_camera_orientation()was readingself.default_camera_orientation_kwargs, which does not exist.This caused the method to raise an
AttributeErrorinstead of applying the default angled camera orientation. This PR switches the method to the correct attribute and adds a regression test covering both the defaultthetaand aphioverride.Links to added or changed documentation pages
N/A
Further Information and Comments
Issue: #4472
Tested with:
.venv/bin/pytest tests/module/scene/test_threed_scene.py -q -n0