Skip to content

Added regression test for inconsistent stroke width scaling for text in compound objects#4703

Open
vihdutta wants to merge 1 commit intoManimCommunity:mainfrom
vihdutta:consistent_mobject_scaling_test
Open

Added regression test for inconsistent stroke width scaling for text in compound objects#4703
vihdutta wants to merge 1 commit intoManimCommunity:mainfrom
vihdutta:consistent_mobject_scaling_test

Conversation

@vihdutta
Copy link
Copy Markdown
Contributor

Overview: What does this pull request change?

Based on my already merged PR (#4694), I wanted to add a regression test (the test fails before my merged PR code, and succeeds after it). This regression test is based on the original code that reproduced the issue (#4648). I noted it may be important considering I believe I fixed another bug (#4701) with a similar issue.

Motivation and Explanation: Why and how do your changes improve the library?

Bugfix.

Links to added or changed documentation pages

I briefly explained that the added test is a regression test and cited the issue that it corresponds with in the test file.

Further Information and Comments

Reviewer Checklist

  • The PR title is descriptive enough for the changelog, and the PR is labeled correctly
  • If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
  • If applicable: newly added functions and classes are tested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant