Added regression test for inconsistent stroke width scaling for text in compound objects#4703
Open
vihdutta wants to merge 1 commit intoManimCommunity:mainfrom
Open
Added regression test for inconsistent stroke width scaling for text in compound objects#4703vihdutta wants to merge 1 commit intoManimCommunity:mainfrom
vihdutta wants to merge 1 commit intoManimCommunity:mainfrom
Conversation
…in compound objects
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview: What does this pull request change?
Based on my already merged PR (#4694), I wanted to add a regression test (the test fails before my merged PR code, and succeeds after it). This regression test is based on the original code that reproduced the issue (#4648). I noted it may be important considering I believe I fixed another bug (#4701) with a similar issue.
Motivation and Explanation: Why and how do your changes improve the library?
Bugfix.
Links to added or changed documentation pages
I briefly explained that the added test is a regression test and cited the issue that it corresponds with in the test file.
Further Information and Comments
Reviewer Checklist