treat explicit undefined as "use the default" to match JS native behavior

.github/workflows/cmake.yml

@@ -9,7 +9,46 @@ concurrency:
   cancel-in-progress: true
 
 jobs:
+  changes:
+    runs-on: ubuntu-latest
+    outputs:
+      code: ${{ steps.filter.outputs.code }}
+    steps:
+    - uses: actions/checkout@v4
+    - uses: dorny/paths-filter@v3
+      id: filter
+      with:
+        filters: |
+          code:
+            - 'v8pp/**'
+            - 'test/**'
+            - 'plugins/**'
+            - 'examples/**'
+            - 'CMakeLists.txt'
+            - 'cmake/**'
+            - '.github/workflows/**'
+
+  format:
+    needs: changes
+    if: needs.changes.outputs.code == 'true'
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v4
+    - name: Install clang-format-19
+      run: |
+        wget -qO- https://apt.llvm.org/llvm-snapshot.gpg.key | sudo tee /etc/apt/trusted.gpg.d/apt.llvm.org.asc
+        echo "deb http://apt.llvm.org/noble/ llvm-toolchain-noble-19 main" | sudo tee /etc/apt/sources.list.d/llvm-19.list
+        sudo apt-get update && sudo apt-get install -y clang-format-19
+    - name: Check formatting with clang-format
+      run: |
+        find v8pp test plugins \
+          -path '*/out/*' -prune -o \
+          \( -name '*.hpp' -o -name '*.cpp' -o -name '*.ipp' \) -print | \
+          xargs clang-format-19 --dry-run --Werror
+
   build:
+    needs: changes
+    if: needs.changes.outputs.code == 'true'
     timeout-minutes: 30
     strategy:
       fail-fast: false
@@ -36,7 +75,7 @@ jobs:
     steps:
     - uses: actions/checkout@v4
 
-    - name: Install V8 apt 
+    - name: Install V8 apt
       if: startsWith(matrix.os, 'ubuntu')
       run: sudo apt update && sudo apt install libv8-dev -y
 
@@ -67,8 +106,22 @@ jobs:
     - name: Install ninja-build tool
       uses: seanmiddleditch/gha-setup-ninja@v5
 
+    - name: Set up ccache
+      if: ${{ !startsWith(matrix.os, 'windows') }}
+      uses: hendrikmuhs/ccache-action@v1
+      with:
+        key: ${{matrix.os}}-${{matrix.shared_lib}}-${{matrix.header_only}}
+
     - name: Configure CMake
-      run: cmake -G Ninja -B ${{github.workspace}}/build -DCMAKE_BUILD_TYPE=${{matrix.build_type}} -DBUILD_TESTING=TRUE -DBUILD_SHARED_LIBS=${{matrix.shared_lib}} -DV8PP_HEADER_ONLY=${{matrix.header_only}} -DV8_COMPRESS_POINTERS=${{matrix.v8_compress_pointers}} -DV8_ENABLE_SANDBOX=${{matrix.v8_enable_sandbox}}
+      run: >
+        cmake -G Ninja -B ${{github.workspace}}/build
+        -DCMAKE_BUILD_TYPE=${{matrix.build_type}}
+        -DBUILD_TESTING=TRUE
+        -DBUILD_SHARED_LIBS=${{matrix.shared_lib}}
+        -DV8PP_HEADER_ONLY=${{matrix.header_only}}
+        -DV8_COMPRESS_POINTERS=${{matrix.v8_compress_pointers}}
+        -DV8_ENABLE_SANDBOX=${{matrix.v8_enable_sandbox}}
+        ${{ !startsWith(matrix.os, 'windows') && '-DCMAKE_C_COMPILER_LAUNCHER=ccache -DCMAKE_CXX_COMPILER_LAUNCHER=ccache' || '' }}
 
     - name: Build
       run: cmake --build ${{github.workspace}}/build --config ${{matrix.build_type}}

plugins/file.cpp

@@ -94,8 +94,7 @@ v8::Local<v8::Value> init(v8::Isolate* isolate)
 		.function("close", &file_base::close)
 		.function("good", &file_base::good)
 		.function("is_open", &file_base::is_open)
-		.function("eof", &file_base::eof)
-		;
+		.function("eof", &file_base::eof);
 
 	// .ctor<> template arguments declares types of file_writer constructor
 	// file_writer inherits from file_base_class
@@ -105,8 +104,7 @@ v8::Local<v8::Value> init(v8::Isolate* isolate)
 		.inherit<file_base>()
 		.function("open", &file_writer::open)
 		.function("print", &file_writer::print)
-		.function("println", &file_writer::println)
-		;
+		.function("println", &file_writer::println);
 
 	// .ctor<> template arguments declares types of file_reader constructor.
 	// file_base inherits from file_base_class
@@ -115,16 +113,13 @@ v8::Local<v8::Value> init(v8::Isolate* isolate)
 		.ctor<char const*>()
 		.inherit<file_base>()
 		.function("open", &file_reader::open)
-		.function("getln", &file_reader::getline)
-		;
+		.function("getln", &file_reader::getline);
 
 	// Create a module to add classes and functions to and return a
 	// new instance of the module to be embedded into the v8 context
 	v8pp::module m(isolate);
 	m.function("rename", +[](char const* src, char const* dest) -> bool
-	{
-		return std::rename(src, dest) == 0;
-	});
+		{ return std::rename(src, dest) == 0; });
 	m.class_("writer", file_writer_class);
 	m.class_("reader", file_reader_class);
 

test/main.cpp

@@ -36,30 +36,29 @@ void run_tests()
 	void test_adversarial();
 	void test_thread_safety();
 
-	std::pair<char const*, void (*)()> tests[] =
-	{
+	std::pair<char const*, void (*)()> tests[] = {
 		{ "test_type_info", test_type_info },
-		{"test_utility", test_utility},
-		{"test_context", test_context},
-		{"test_context_store", test_context_store},
-		{"test_convert", test_convert},
-		{"test_throw_ex", test_throw_ex},
-		{"test_function", test_function},
-		{"test_ptr_traits", test_ptr_traits},
-		{"test_call_v8", test_call_v8},
-		{"test_call_from_v8", test_call_from_v8},
-		{"test_module", test_module},
-		{"test_class", test_class},
-		{"test_property", test_property},
-		{"test_object", test_object},
-		{"test_json", test_json},
-		{"test_overload", test_overload},
-		{"test_fast_api", test_fast_api},
-		{"test_symbol", test_symbol},
-		{"test_promise", test_promise},
-		{"test_gc_stress", test_gc_stress},
-		{"test_adversarial", test_adversarial},
-		{"test_thread_safety", test_thread_safety},
+		{ "test_utility", test_utility },
+		{ "test_context", test_context },
+		{ "test_context_store", test_context_store },
+		{ "test_convert", test_convert },
+		{ "test_throw_ex", test_throw_ex },
+		{ "test_function", test_function },
+		{ "test_ptr_traits", test_ptr_traits },
+		{ "test_call_v8", test_call_v8 },
+		{ "test_call_from_v8", test_call_from_v8 },
+		{ "test_module", test_module },
+		{ "test_class", test_class },
+		{ "test_property", test_property },
+		{ "test_object", test_object },
+		{ "test_json", test_json },
+		{ "test_overload", test_overload },
+		{ "test_fast_api", test_fast_api },
+		{ "test_symbol", test_symbol },
+		{ "test_promise", test_promise },
+		{ "test_gc_stress", test_gc_stress },
+		{ "test_adversarial", test_adversarial },
+		{ "test_thread_safety", test_thread_safety },
 	};
 
 	for (auto const& test : tests)
@@ -91,22 +90,21 @@ int main(int argc, char const* argv[])
 		if (arg == "-h" || arg == "--help")
 		{
 			std::cout << "Usage: " << argv[0] << " [arguments] [script]\n"
-				<< "Arguments:\n"
-				<< "  --help,-h           Print this message and exit\n"
-				<< "  --version,-v        Print V8 version\n"
-				<< "  --lib-path <dir>    Set <dir> for plugins library path\n"
-				<< "  --run-tests         Run library tests\n"
-				;
+					  << "Arguments:\n"
+					  << "  --help,-h           Print this message and exit\n"
+					  << "  --version,-v        Print V8 version\n"
+					  << "  --lib-path <dir>    Set <dir> for plugins library path\n"
+					  << "  --run-tests         Run library tests\n";
 			return EXIT_SUCCESS;
 		}
 		else if (arg == "-v" || arg == "--version")
 		{
 			std::cout << "V8 version " << v8::V8::GetVersion() << std::endl;
 			std::cout << "v8pp version " << v8pp::version()
-				<< " (major=" << v8pp::version_major()
-				<< " minor=" << v8pp::version_minor()
-				<< " patch=" << v8pp::version_patch()
-				<< ")\n";
+					  << " (major=" << v8pp::version_major()
+					  << " minor=" << v8pp::version_minor()
+					  << " patch=" << v8pp::version_patch()
+					  << ")\n";
 			std::cout << "v8pp build options " << v8pp::build_options() << std::endl;
 		}
 		else if (arg == "--lib-path")
@@ -128,7 +126,7 @@ int main(int argc, char const* argv[])
 	// for v8pp::class_ tests
 	v8::V8::SetFlagsFromString("--expose_gc");
 
-	//v8::V8::InitializeICU();
+	// v8::V8::InitializeICU();
 	v8::V8::InitializeExternalStartupData(argv[0]);
 #if V8_MAJOR_VERSION >= 7
 	std::unique_ptr<v8::Platform> platform(v8::platform::NewDefaultPlatform());

test/test.hpp

@@ -151,7 +151,8 @@ std::ostream& operator<<(std::ostream& os, std::pair<First, Second> const& pair)
 	return os << pair.first << ": " << pair.second;
 }
 
-template<typename Enum> requires std::is_enum_v<Enum>
+template<typename Enum>
+requires std::is_enum_v<Enum>
 std::ostream& operator<<(std::ostream& os, Enum value)
 {
 	return os << static_cast<typename std::underlying_type_t<Enum>>(value);
@@ -167,12 +168,11 @@ template<typename... Ts>
 std::ostream& operator<<(std::ostream& os, std::tuple<Ts...> const& tuple)
 {
 	std::apply([&os](auto&&... elems) mutable
-	{
+		{
 		bool first = true;
 		os << '(';
 		((os << (first ? (first = false, "") : ", ") << elems), ...);
-		os << ')';
-	}, tuple);
+		os << ')'; }, tuple);
 	return os;
 }