feat: native mentions in Chat, Tasks and Knowledge - #352
Merged
Merged
Conversation
Maneek21
marked this pull request as ready for review
October 2, 2026 13:05
Maneek21
marked this pull request as draft
October 2, 2026 13:38
Maneek21
marked this pull request as ready for review
October 2, 2026 14:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds one @ picker for people, agents, tasks and wikis across Chat, Tasks and Knowledge: messages/replies, task descriptions/comments and wiki bodies. Tasks and wikis open as links and show authorized backlinks. Human Send/Post or explicit Notify mentions publishes eligible notifications; document agent mentions create passive attention. Existing explicit chat invocation and shared conversation storage retain their owners.
Core owns identity, authorization, current reference state, saved-hash publication and durable delivery. Existing manual/module relationships are preserved. Defty and bound employee MCP tools discover exact tokens, read authorized source context and consume their own attention. Agent writes reject unavailable targets before proposal/approval creation and again at execution. Resource scopes are opt-in and do not broaden existing credentials. Bounded parsing excludes literal/quoted content.
Validation and evidence
a0cd499d, desktop/recipient/mobile, live socket, save/navigation/Notify flows and model-prefix rendering.gpt-5.4-mini, 8/8 passed, 24 actual requests. Real Defty runner and real authenticated MCP handlers cover grounded references/facts, governed writes, passive attention, private/tenant boundaries, changed permissions, own acknowledgement, approval queues and renamed records. Synthetic fixtures cleaned; key never persisted. Sanitized traces are in the local review report outside Git. Earlier failing runs are retained; this does not certify every model or a deployed third-party runtime. Final a0cd499 only narrows wrapping for unrelated MCP tools; native handlers and guidance are unchanged. The opt-in harness is apps/api/test/live-native-mentions.ts.Excluded: Notes, Calendar, Canvas, Email and custom App Kit records. Feature defaults off;
DEFT_NATIVE_MENTIONS_ENABLED=trueenables the pilot. Additive preview.61 migration avoids the separate Platform/Email candidate's reserved .31–.60; combined manifests/checksums and joint release checks remain an integration gate. UI recordings use offline test identities; live provider behavior has separate transcript evidence.Closes #351.