series: missing Audible/MAM part no longer aborts the run - #24
Merged
Merged
Conversation
product2Book required series.sequence and getMAMBook required series_info[1], so an unnumbered series entry crashed matching and skipped every later book. Treat a missing/null part as empty (in_series_no_part) instead of "#None". Co-authored-by: Mancolt <Mancolt@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Review of the rebased PR found that a null/number/bare-string value, or a null name, still raised TypeError or filed the book under a series named None. Guard both, as product2Book already does for Audible. Co-authored-by: Cursor <cursoragent@cursor.com>
Mancolt
force-pushed
the
cursor/critical-bug-management-d57e
branch
from
September 22, 2026 14:51
09ce5b4 to
5d02741
Compare
Mancolt
marked this pull request as ready for review
September 22, 2026 14:56
Merged
Mancolt
added a commit
that referenced
this pull request
Sep 22, 2026
Moves the two ## Unreleased entries (#22 bitrate-folder grouping, #24 unnumbered series) under a ## 3.0.3 - 2026-09-22 heading. Tag v3.0.3 already points at the #24 merge commit and the image ghcr.io/mancolt/booktree:3.0.3 is built and deployed; this is the matching release note only. No code change. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
Matching a book that Audible lists in a series without a
sequence(companion books, unnumbered entries) raisedKeyErrorinproduct2Book._rankAudibledoes not catch that, so the whole run exited 1 and every later book was skipped. The same crash happened ingetMAMBookwhen MAMseries_infowas["Name"]or["Name", null](IndexErrorons[1]). When the part was present butnull,str(None)filed the book asSeries #None - Titleinstead of usingin_series_no_part.Root cause
product2Bookrequireds["sequence"].getMAMBookrequired a second list element.#17already treated an empty part asin_series_no_part, but a missing/null part never reached that path.Fix
product2Bookwalksserieswiths.get("sequence")and skips entries that are not a dict with a title.getMAMBooktreats a missing or null second element as no part.Series.__post_init__coercesNone/int parts to strings sogetSeriesPartcannot crash andin_series_no_partis used.Validation
series_info, andgetConfigTargetPath. They fail on the olds["sequence"]/s[1]access.Also still awaiting review: the 64k/ grouping fix in #22