Repository navigation
Add automatic sslip HTTPS access mode - #6
Draft
Mammad3861 wants to merge 1 commit into
Draft
Mammad3861 wants to merge 1 commit into
Mammad3861 wants to merge 1 commit into
Conversation
Mammad3861
marked this pull request as ready for review
September 12, 2026 17:25
Mammad3861
marked this pull request as draft
September 12, 2026 17:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an explicit three-mode HTTPS access workflow:
Configuration
Adds:
ILB_ACCESS_MODE=ip|sslip|domainBackward-compatible behavior is preserved:
ILB_DOMAIN=selects IP mode.ILB_DOMAINselects custom-domain mode.Interactive installs show the three HTTPS choices and default to IP mode.
sslip.io mode
Security and compatibility
Documentation
Documents all three HTTPS modes, including the sslip.io third-party dependency, IP exposure, public port requirements, possible certificate rate limits, and the recommendation to use a custom domain for stable deployments.
Verification
git diff --check: passedbash -n browser.sh tests/browser_test.sh: passedbash tests/browser_test.sh: passedSKIP: streamed TTY tests require the util-linux script commandPASS: browser.sh checksAll Docker, curl, public-IP, and network operations were mocked during local tests.
Remaining runtime validation
Before merging, validate on a real VPS:
Linux CI should exercise the util-linux pseudo-terminal tests.