Repository navigation
Fix streamed credential prompts - #4
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix streamed installations where sequential username and password prompts could stall or lose terminal input.
Root cause
The interactive credential helpers were called through command substitutions. Each prompt therefore ran inside a separate subshell while reading from the controlling terminal, breaking sequential
/dev/ttyinput during piped installations.Changes
printf -v.adminusername behavior.Validation
bash -n browser.sh tests/browser_test.sh— passed.bash tests/browser_test.sh— passed locally; PTY-specific tests were skipped because util-linuxscriptis unavailable in Git Bash.3001responded with the expected401 Unauthorizedbefore credentials.Scope
No Docker image, port mapping, Chromium flag, security setting, diagnostics, README, or workflow behavior was changed.