HD108 method using PARLIO peripheral on ESP32-C6#907
Open
tommag wants to merge 3 commits intoMakuna:masterfrom
Open
HD108 method using PARLIO peripheral on ESP32-C6#907tommag wants to merge 3 commits intoMakuna:masterfrom
tommag wants to merge 3 commits intoMakuna:masterfrom
Conversation
Without setting valid_gpio_num to -1, GPIO0 will be setup for the valid signal
Makuna
requested changes
Feb 13, 2026
Owner
Makuna
left a comment
There was a problem hiding this comment.
just some minor style updates needed
| private: | ||
| void initParlio() | ||
| { | ||
| parlio_tx_unit_config_t config = { |
Owner
There was a problem hiding this comment.
code style:
This library uses the "curly braces on their own line" format style.
While in general initialization (like this line) are often not strictly inforced, it more important for branching statements EVEN if they are single line (see below).
| _wire.transmitBytes(startFrame, sizeof(startFrame)); | ||
| //start frame : 128bits (16bytes) with DIN = 0 | ||
| for (int i = 0; i < 16; i++) | ||
| _wire.transmitByte(0x00); |
Owner
There was a problem hiding this comment.
code style:
This library uses the "all code blocks require wrapping curly braces" and "curly braces on their own line" format styles.
so this needs to change to something like...
for (int i = 0; i < 16; i++)
{
_wire.transmitByte(0x00);
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Here is a method to use the new PARLIO peripheral in ESP32-C5 / C6 / P4 / H2 / H4
I have only defined it for the HD108 type yet but it should be pretty easy to adapt for other 2 wire LEDs, while freeing the SPI controller for other tasks.
I also fixed the generic HD108 method that had refresh issues.
Tested with an ESP32-C6 and HD108 LEDs at max 10MHz (but should work up to 40MHz).
Thanks for sharing your work and for the nice code architecture, I enjoyed adding features to the lib which is not always the case !