Repository navigation
fix(release-vote-tally): keep email-only roster voters distinct - #28
Draft
MakerFlyFly wants to merge 1 commit into
Draft
MakerFlyFly wants to merge 1 commit into
MakerFlyFly wants to merge 1 commit into
Conversation
Roster membership can resolve through Primary email without an Apache ID. Using the empty ID as a shared identity let different members supersede each other, causing both missing approvals and missing dissenting votes. Use the existing normalized-address identity when the Apache ID is absent. Keep roster-ID identities, binding resolution, and pass rules unchanged. Generated-by: Codex (GPT-6)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of change
tools/release-management)Test plan
30ee18c2before the fix and pass afterward.prek run --all-files --skip workspace-pytest— passes, including lychee, symlink checks, and workspace-wide static checks.prek run workspace-pytest --from-ref origin/main --to-ref HEAD— passes.Independent follow-up verification
RFC-AI-0004 compliance
Linked issues
Closes #27.
Notes for reviewers
The two failure examples use synthetic identities. A missing ID does not remove binding status: eligibility is still resolved independently through the primary email.
Audit-report handle resolution is outside this PR. No release action or merge is performed by this change. Upstream submission is linked below.
Windows full-package validation limits
With UTF-8 enabled and Git Bash on the test process PATH, the full package reports 716 passed, 2 failed (11 subtests passed). The baseline checkout at 634ab08 reports 709 passed and the same two failures; Git comparison confirms the relevant packages are unchanged between that checkout and PR base 30ee18c.
These baseline failures do not involve voter identity. The Linux full-package run and the actual GitHub test task pass. Windows compatibility work is outside this counting fix.
AI disclosure and human audit
AI-assisted work prepared with Codex (GPT-6). The contributor has completed review of the patch and validation results and authorized upstream submission. This fork Draft PR is retained as the audit snapshot.
Upstream submission
1089c512a04af5786ea70ef22e813e9ab400854b.32407c7087c614592a20a6e369361738fcc31c6a, based on6fafad25b1b1bc239c8863d09d757fa3cf71d72a.