Repository navigation
ci: give each main-branch push its own concurrency group - #57
Merged
Merged
Conversation
Co-authored-by: polylane[bot] <277585245+polylane[bot]@users.noreply.github.com>
Author
|
Note Production impact unlikely. Documentation, test, or CI-only change; nothing that runs in production is affected. Polylane analysed Did this help? React 👍 or 👎 so the next review is sharper. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: Mail-0/comet ci.yml self-cancels main-branch runs (concurrency group on constant refs/heads/main)
Comet's CI workflow shared one concurrency group across every push to main, so a newer push cancelled the run for the older commit and that commit was never fully verified. Each main-branch push now gets its own group and superseded runs are cancelled only for pull requests, so a run for every pushed commit reaches a conclusion.
Detection evidence
Affected:
int_0c7912e40001wiz7sd656fidWhy this fix
Live run history for the ci workflow on main shows 14 of the last 40 push runs ended cancelled, each superseded by the next push. Making cancel-in-progress conditional alone does not fix this: a shared group still cancels a queued run when a newer one joins. Keying the push case on the run id gives every push its own group, matching the pattern Mail-0/sms-kit already uses. Impact stays low here because comet's release is tag-triggered and main requires no status check.
Out of scope
Causal chain
1 file changed (+6/-2)
.github/workflows/ci.yml: modified, +6/-2Generated by Polylane. You can ask follow-ups by mentioning @polylane in a comment.