Skip to content

Fix #189 User profiles not removed using WinDeleteUserProfiles.ps1 - #194

Closed
pomodori92 wants to merge 13 commits into
Magnetarman:Devfrom
pomodori92:FIX_#189_ProfilesNotRemoved_WinDeleteUserProfiles
Closed

pomodori92 wants to merge 13 commits into
Magnetarman:Devfrom
pomodori92:FIX_#189_ProfilesNotRemoved_WinDeleteUserProfiles

Conversation

@pomodori92

@pomodori92 pomodori92 commented Oct 6, 2026 •

Copy link
Copy Markdown

Description

WinDeleteUserProfiles.ps1:

  • it didn't remove the user profiles or the user folders, now it does;
  • renamed $profile variable in $profileItem because there is a built-in $profile variable in PowerShell to avoid side-effects;
  • added comments.

Fixes #

#189


Type of Change

  • 🐛 Bug fix
  • ✨ New feature
  • ♻️ Refactoring (no functional change)
  • 🧹 Cleanup / Maintenance
  • 📖 Documentation

Files Modified

  • .github/tests/Unit/WinDeleteUserProfiles.Tests.ps1 — Added WinDeleteUserProfiles.Tests.ps1 unit test file.
  • .github/workflows/_reusable-lint-test.yml — Added unit tests file.
  • tools/WinDeleteUserProfiles.ps1 — Now it removes user profiles and folders.

Tests & Verification

  • Verified locally via the relevant build/test command
  • If CI/CD changed, validated the affected workflow/action and updated the tracking document
  • Execution logs attached (snippet or screenshot)
Log / Screenshot
Paste relevant logs here

Checklist

Missing a checkbox or violating a rule will result in automatic PR rejection.

  • PR targets Dev unless this is an authorized maintainer release change
  • Atomic change: one issue or one feature per PR
  • WinToolkit.ps1 not modified manually (handled by CI automation)
  • Generated artifacts (WinToolkit.ps1, start-core.ps1) are not edited manually
  • Changes to .github/, start.ps1 or start-modules/ include the required maintainer review
  • Existing code style respected, no debug code left behind
  • Clear commits in Italian, max 72 characters per line

@pomodori92
pomodori92 marked this pull request as draft October 8, 2026 07:42
@pomodori92 pomodori92 closed this Nov 1, 2026
@pomodori92
pomodori92 deleted the FIX_#189_ProfilesNotRemoved_WinDeleteUserProfiles branch November 1, 2026 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant