Skip to content

Handle missing password authentication cleanly #1351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elprans merged 4 commits into from
Sep 24, 2026
+6 −1
Merged

Handle missing password authentication cleanly #1351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e96529b
fix: handle missing cleartext password cleanly
Aug 16, 2026
f2dcd13
Merge branch 'master' into fix/1286-missing-password-error
elprans Sep 24, 2026
8f79fba
test: isolate missing cleartext password case
elprans Sep 24, 2026
29214e0
fix: report missing cleartext password as authentication failure
elprans Sep 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion asyncpg/protocol/coreproto.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -675,7 +675,7 @@ cdef class CoreProtocol:
WriteBuffer msg

msg = WriteBuffer.new_message(b'p')
msg.write_bytestring(self.password.encode(self.encoding))
msg.write_bytestring((self.password or '').encode(self.encoding))
msg.end_message()

return msg
Expand Down
5 changes: 5 additions & 0 deletions tests/test_connect.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,6 +270,11 @@ async def test_auth_password_cleartext(self):
user='password_user',
password='wrongpassword')

async def test_auth_password_cleartext_without_password(self):
with self.assertRaises(asyncpg.InvalidPasswordError):
await self._try_connect(
user='password_user', password=lambda: None)

async def test_auth_password_cleartext_callable(self):
def get_correctpassword():
return CORRECT_PASSWORD
Expand Down
Loading