feat: Update Go modules and fix LDAP import path#25
Open
mshedsilegx wants to merge 21 commits intoMacmod:mainfrom
Open
feat: Update Go modules and fix LDAP import path#25mshedsilegx wants to merge 21 commits intoMacmod:mainfrom
mshedsilegx wants to merge 21 commits intoMacmod:mainfrom
Conversation
This commit updates several Go modules to their latest versions, including `github.com/go-ldap/ldap`, `github.com/rivo/tview`, and others. It also fixes an incorrect import path in `pkg/ldaputils/actions.go`, changing `github.com/go-ldap/ldap/gssapi` to `github.com/go-ldap/ldap/v3/gssapi`. These changes were followed by `go mod tidy` and a successful build of the project.
This commit addresses the findings from `go vet` after updating the Go modules. The issues were related to unkeyed struct literals in `pkg/ldaputils/actions.go` and `tui/dnsmodify.go`. The struct literals have been updated to use keyed fields, which improves code readability and maintainability.
This commit addresses the findings from `govulncheck` by updating the Go toolchain to `go1.24.4`. This resolves the following vulnerabilities in the standard library: - GO-2025-3750 in `syscall` - GO-2025-3749 in `crypto/x509`
This commit addresses a number of issues reported by `golangci-lint`. The changes include: - Removing unused code. - Replacing deprecated function calls. - Handling unchecked errors. - Fixing other minor linting issues.
…nused. This commit addresses 35 linting issues across the codebase, improving code quality, readability, and adherence to Go best practices. Fixes include: - Handling unchecked error return values. - Formatting error strings correctly. - Refactoring `if-else` chains to `switch` statements. - Removing redundant type declarations. - Replacing `strings.Replace` with `strings.ReplaceAll`. - Removing an unused variable.
Corrected all linting issues reported by errcheck, staticcheck, and u…
…nused. This commit addresses 35 linting issues across the codebase, improving code quality, readability, and adherence to Go best practices. Fixes include: - Handling unchecked error return values. - Formatting error strings correctly. - Refactoring `if-else` chains to `switch` statements. - Removing redundant type declarations. - Replacing `strings.Replace` with `strings.ReplaceAll`. - Removing an unused variable.
Corrected all linting issues reported by errcheck, staticcheck, and u…
This commit addresses all outstanding linting issues reported by errcheck, staticcheck, and unused. These changes improve code quality, readability, and adherence to Go best practices. Fixes include: - Handling all unchecked error return values. - Formatting error strings to be uncapitalized and without trailing punctuation. - Refactoring `if-else` chains to `switch` statements for better readability. - Removing redundant type declarations where the type can be inferred. - Replacing `strings.Replace` with `strings.ReplaceAll`. - Removing an unused variable.
Fix: Correct all linting issues
This commit addresses all outstanding linting issues reported by errcheck, staticcheck, and unused. These changes improve code quality, readability, and adherence to Go best practices. Fixes include: - Handling all unchecked error return values. - Formatting error strings to be uncapitalized and without trailing punctuation. - Refactoring `if-else` chains to `switch` statements for better readability. - Removing redundant type declarations where the type can be inferred. - Replacing `strings.Replace` with `strings.ReplaceAll`. - Removing an unused variable.
Fix: Correct all linting issues
This commit addresses all outstanding linting issues reported by errcheck, staticcheck, and unused. These changes improve code quality, readability, and adherence to Go best practices. Fixes include: - Handling all unchecked error return values. - Formatting error strings to be uncapitalized and without trailing punctuation. - Refactoring `if-else` chains to `switch` statements for better readability. - Removing redundant type declarations where the type can be inferred. - Replacing `strings.Replace` with `strings.ReplaceAll`. - Removing an unused variable.
This commit addresses all outstanding linting issues reported by errcheck, staticcheck, and unused. These changes improve code quality, readability, and adherence to Go best practices. Fixes include: - Handling all unchecked error return values. - Formatting error strings to be uncapitalized and without trailing punctuation. - Refactoring `if-else` chains to `switch` statements for better readability. - Removing redundant type declarations where the type can be inferred. - Replacing `strings.Replace` with `strings.ReplaceAll`. - Removing an unused variable.
Fix linting issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates several Go modules to their latest versions, including
github.com/go-ldap/ldap(vulnerable),github.com/rivo/tview, and others.It also fixes an incorrect import path in
pkg/ldaputils/actions.go, changinggithub.com/go-ldap/ldap/gssapitogithub.com/go-ldap/ldap/v3/gssapi.These changes were followed by
go mod tidyand a successful build of the project. It also addresses many issues detected by go vet, golangci-lint and govulncheck