fix: use cast_column for faster string conversion of label columns (Fixes #145) - #251
Open
rtmalikian wants to merge 1 commit into
Conversation
Replace the slow add_column/remove_columns/rename_column pattern with
datasets.cast_column(task, datasets.Value("string")) for converting
classification label columns to strings.
The previous approach created a new column with str(x) for every element
via a Python list comprehension, then removed the old column and renamed
the new one. This is O(n) Python operations per column.
cast_column operates at the Apache Arrow level, which is dramatically
faster for large datasets because it avoids creating intermediate columns
and leverages Arrow's native type casting.
Fixes Machine-Learning-for-Medical-Language#145
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #145
Problem
The
AutoProcessorincnlp_processors.pyconverts classification label columns from integers to strings using a slow pattern:This creates a new column with a Python list comprehension (
str(x)for every element), removes the old column, and renames the new one. For large datasets, this is extremely slow because it iterates through every element in Python.Solution
Replace the slow pattern with
datasets.cast_column(task, datasets.Value("string")), which operates at the Apache Arrow level:This is dramatically faster because:
Verification
About the Author: Raphael Malikian — Clinical AI Solutions Architect. I specialise in building and fixing AI/ML systems for healthcare, including vector databases, RAG pipelines, and clinical NLP. If you need help with your project or think I can add value to your organisation, feel free to reach out — I'd love to connect.
📧 rtmalikian@gmail.com
🔗 GitHub: https://github.com/rtmalikian
🔗 LinkedIn: http://www.linkedin.com/in/raphael-t-malikian-mbbs-bsc-hons-71075436a
Disclosure: This code was developed with assistance from mimo-2.5-pro (Xiaomi) via Hermes Agent (Nous Research). All changes were reviewed, tested against the actual codebase, and verified for correctness.