Repository navigation
Conversation
MistEO
marked this pull request as ready for review
November 11, 2026 08:43
Contributor
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agent 调用 PostStop 时,MaaFramework 可能拒绝新任务并返回 ID 0;MXU 原先仍把它登记为 pending。控制器断开时,停止标记也可能无法入队,留下 Running 状态和本轮 Agent 子进程。单任务和批量入口现在只登记有效任务 ID,并回收被原生 Stop 丢弃的队列。
每轮增加独立的 idle 检查,处理最后一次普通回调之后发生 Stop、没有后续回调的情况。Start 准入和 Agent 注册后的提交阶段检查旧队列,等待本轮清理再开放下一轮。观察器按实例和轮次隔离,迟到的停止标记不能影响新队列;普通 Stop 仍复用健康 controller。
Web 客户端等待停止时每 800 ms 重发 Stop,可能取消另一客户端刚开始的新队列。现在每次停止操作只发一次请求,成功读到 idle 后才清理前端状态,状态查询失败继续等待。
基于 main
c321532,与 #434 head21494a8对照。独立复审发现并修复了最后一次回调后的漏收尾窗口,以及新实现中的 Start 取锁、同 ID 实例重建和连续状态查询竞态;最终复审无阻塞问题。验证:
pnpm test:123 passed、1 skipped,包含 4 个 Web Stop 回归。前端 build、格式和 Rust 格式检查通过。0xc0000139加载问题,为临时 EXE 副本嵌入 Common Controls v6 manifest 后执行,未修改应用清单。cargo check --all-targets --locked通过。可复跑原生测试和依赖说明位于
tests/windows/task-stop-lifecycle。fixture 直接调用真实 Tasker API;异步追加窗口使用真实 submission permit 和原生 post 模拟 Agent 注册结束后的状态。完整 Agent IPC、真实游戏、设备与打包桌面 UI 未验证。Sourcery 总结
强化原生客户端和 Web 客户端中任务停止与重启的生命周期管理,确保被拒绝或已放弃的队列能够安全清理,同时不影响后续运行。
Bug 修复:
功能增强:
文档:
测试:
Original summary in English
Summary by Sourcery
Harden task stopping and restart lifecycle across native and web clients so rejected or abandoned queues are cleaned up safely without affecting subsequent runs.
Bug Fixes:
Enhancements:
Documentation:
Tests:
AI 使用信息: