Repository navigation
Conversation
MistEO
marked this pull request as ready for review
November 11, 2026 08:43
Contributor
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
截图订阅先于 controller 到达,或实例销毁时仍有订阅,原来的截图循环会在退出后立即反复启动。销毁后以同 ID 建立的新实例还会接收到旧订阅的截图请求。现在无 controller 时等待帧间隔,销毁实例时同步移除订阅,已断连的 controller 暂停主动截图。
Dashboard 和截图面板共用可取消的读取循环。每个视图使用独立订阅 ID 并每 10 秒续订,防止 30 秒订阅到期后画面冻结。重连、切换实例和折叠时,迟到的帧及旧定时器会退出。Dashboard 在任务运行中断连后仍提供 Stop。
基于 main
c321532,经独立 review 未发现阻塞问题。回归保留普通 Stop 后对健康 controller 的复用。#393 涉及同一 Dashboard 文件的启动编排,合并时可能需要处理同文件冲突。验证:
pnpm test:screenshots:26/26。实际挂载 React 组件,使用受控 Maa RPC 和 Chromium 虚拟时间,覆盖续订、多个视图、迟到帧、重连、切换和暂停。同组外部 fixture 在原 main 上 12 项通过、14 项失败。0xc0000139加载问题,给临时副本嵌入 Common Controls v6 manifest 后实际执行,步骤见tests/screenshots/README.md。pnpm test:119 passed、1 skipped;pnpm build、前端格式、Rust 格式及 diff 检查通过。打包桌面 UI、真实设备和实际游戏画面未验证。已有的长间隔等待行为保留:后台正在等待 30 秒时,切换更快帧率仍可能等完旧间隔。
Sourcery 摘要
稳定后端与 UI 中的截图订阅和重连生命周期,避免视图或实例发生变化后仍有过时操作继续执行。
新功能:
错误修复:
改进:
构建:
文档:
测试:
Original summary in English
Summary by Sourcery
Stabilize screenshot subscription and reconnection lifecycles across the backend and UI while preventing stale work from surviving view or instance changes.
New Features:
Bug Fixes:
Enhancements:
Build:
Documentation:
Tests:
AI 使用信息: