Repository navigation
Conversation
MistEO
marked this pull request as ready for review
November 11, 2026 02:37
Contributor
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
清理更新备份时,原来的递归通过 Path::is_dir 跟随目录链接。旧目录内存在 Windows junction 或目录符号链接时,清理可能进入链接目标并删除其中的用户数据。
现在在递归入口读取不跟随链接的元数据,Windows 同时识别目录重解析点,只解除链接。保留逐项继续清理:遇到占用文件、枚举或元数据错误会累计失败并继续处理兄弟项。成功删除目录现在也纳入日志计数;两个调用方均只记录计数。
两轮独立 review 通过。5 项新增测试覆盖正常嵌套目录、嵌套和根 junction、悬空链接,以及独占打开文件后继续清理兄弟项。Windows 实际 junction 和独占文件验证通过;Unix 符号链接路径已静态审查,本地未执行。
验证:Windows 完整 crate 的 Cargo lib-test 编译通过。原测试 exe 因现有 Common Controls v6 manifest 缺失而在加载阶段退出;给该编译产物的副本嵌入 Tauri 默认 manifest 后,cleanup_ 过滤命中的 6 项测试全部通过(5 项新增、1 项既有)。rustfmt 和 git diff --check 通过。
基于 main c321532。本次没有更改调用方原有的 exists 检查,也不处理元数据检查与遍历之间的并发链接替换。
Sourcery 摘要
使 update-backup 清理能够安全地处理目录链接,同时继续尽力删除,并准确报告结果。
错误修复:
增强功能:
测试:
Original summary in English
Summary by Sourcery
Make update-backup cleanup safe for directory links while continuing best-effort removal and accurately reporting results.
Bug Fixes:
Enhancements:
Tests:
AI 使用信息: