Repository navigation
Conversation
MistEO
marked this pull request as ready for review
November 11, 2026 08:43
Contributor
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
同一实例收到 Stop 后立即开始下一轮,旧 pretask 还没轮询到停止标记,下一轮的 reset 就会清除它,旧子进程因此继续运行。现在每轮等待者持有自己的取消接收端,reset 开放下一轮时保留旧等待者的停止状态。
已置 Stop 的 pretask 会在创建进程前返回取消。受管 pretask 在取消后等待直接子进程退出,再完成本次调用。等待型前置程序继续只取消等待,允许该程序自行结束。桌面和 Web 入口共用取消注册表。
独立 review 未发现阻塞问题。基于最新 main
c321532,与 #434 head21494a8对照。可复跑回归位于tests/pretask,执行生产命令代码和有时限的真实子进程:python tests/pretask/run.py --offline:7 个进程断言和 2 个注册表单测通过。同一回归在 main 上 3 项通过、4 项失败,复现 Stop/reset 丢取消、返回时未等子进程退出、已停止仍启动和前置程序等待丢取消。0xc0000139,为临时测试 EXE 副本嵌入 Common Controls v6 manifest 后执行,未修改应用配置。cargo fmt --check、独立测试源 rustfmt 和git diff --check通过。Stop 请求表示已登记取消,跨客户端的新调用可能与旧进程退出短暂重叠。测试不覆盖任意孙进程树、Tauri/HTTP 传输或真实项目进程。
Sourcery 摘要
在重置期间保留每次运行的预任务取消状态,并确保托管预操作和用户配置的预操作具有一致的取消完成行为。
Bug 修复:
增强功能:
文档:
测试:
Original summary in English
Summary by Sourcery
Preserve per-run pretask cancellation across resets and make cancellation completion consistent for managed and user-configured pre-actions.
Bug Fixes:
Enhancements:
Documentation:
Tests:
AI 使用信息: