Add Summoner Curse Skills and Lightning Shock Skill Fix by ze-dom · Pull Request #738 · MUnique/OpenMU

ze-dom · 2026-03-26T18:19:50Z

To-do

UpdatePlugins (after discussion)
Comment changes with source references

Developments

Summoner's Explosion, Requiem and Pollution skills (book) and their magic effects
Summoner's Lightning Shock skill completion
Added Skill.SkipElementalModifierto bypass element resistance checks

ze-dom · 2026-03-26T18:29:06Z

src/GameLogic/PlayerActions/Skills/AreaSkillAttackAction.cs

-                    var hitChance = attackRound < areaSkillSettings.MinimumNumberOfHitsPerTarget
-                        ? 1.0
-                        : Math.Min(areaSkillSettings.HitChancePerDistanceMultiplier, Math.Pow(areaSkillSettings.HitChancePerDistanceMultiplier, player.GetDistanceTo(target)));


Pretty sure this is not accurate for Flame and Twister. Those may sometimes not hit at all. Will check it another time. For now I've kept it as it was.

Yea, it's hard to replicate the exact same logic on server side. Flame and Twisters hits were originally calculated on the client side, when rendering each frame(!), depending on the actual (random) animation. So, increasing the frame rate from 25 to 60 fps led to a higher chance of hits 😄

ze-dom · 2026-03-27T11:11:49Z

src/GameLogic/PlayerActions/Skills/PollutionSkillPlugIn.cs

+            currentTarget = nextTarget;
+        }
+
+        await movableTarget.MoveAsync(currentTarget).ConfigureAwait(false);


emu, zTeamS6.3

ze-dom · 2026-03-27T11:13:18Z

src/GameLogic/PlayerActions/Skills/RequiemSkillPlugIn.cs

+                await observable.ForEachWorldObserverAsync<IObjectMovedPlugIn>(p => p.ObjectMovedAsync(walkSupporter, MoveType.Instant), true).ConfigureAwait(false);
+            }
+        }
+    }


emu, zTeamS6.3

ze-dom · 2026-03-27T11:19:33Z

src/GameLogic/AttackableExtensions.cs

-        {
-            return false;
-        }
+        var skipModifier = skillEntry.Skill.SkipElementalModifier;


Only the early seasons skills (S1, S2) use the elemental resistance checks:
emu, zTeamS6.3

ze-dom · 2026-03-27T11:33:13Z

src/GameLogic/AttackableExtensions.cs

+                return;
+            }
+
+            var multiplier = magicEffectDefinition.Number == ExplosionMagicEffectNumber ? attacker.Attributes[Stats.BleedingDamageMultiplier] : 0.6f;


emu, zTeamS6.3
Because the FireTomeMastery (Explosion skill) is a passive, we need to hardcode 0.6f here, otherwise you can use Requiem skill and also get the FireTomeMastery multiplier bonus.

ze-dom · 2026-03-27T12:10:28Z

src/GameServer/MessageHandler/AreaSkillAttackHandlerPlugIn.cs

+                    await this._attackAction.AttackAsync(player, extraTargetId, PollutionSkillId, point, rotation).ConfigureAwait(false);
+                }
+            });
+        }


emu: ObjUseSkill.cpp, user.cpp, zTeamS6.3: ObjectUseSkill.cpp, user.cpp
64-59 = 5

Video of skill display:
https://www.youtube.com/watch?v=Gpmxlw3kjsc

ze-dom · 2026-03-27T12:12:59Z

src/Persistence/Initialization/Skills/SkillsInitializerBase.cs

+            skill.SkipElementalModifier = true;
+            skill.MagicEffectDef = this.CreateEffect(ElementalType.Ice, MagicEffectNumber.Iced, Stats.IsIced, 2);
+            return;
+        }


emu, zTeamS6.3

ze-dom · 2026-03-27T12:16:12Z

src/Persistence/Initialization/Skills/StunEffectInitializer.cs

+        isStunnedPowerUpDefinition.Boost = this.Context.CreateNew<PowerUpDefinitionValue>();
+        isStunnedPowerUpDefinition.Boost.ConstantValue.Value = 1;
+    }
+}


Didn't add any duration because from what I've seen so far the effect is not default to any skill, so it's more called in an ad hoc fashion.

ggmammoth · 2026-03-27T12:21:39Z

I want to implement a stun mechanic with a percentage chance and a fixed duration.
When a skill or attack is executed, I generate a random value between 0 and 1 and compare it to a predefined stun chance (for example, 20%). If the random value is within that chance, I apply a stun effect to the target for a specific duration (for example, 3 seconds).

// stun chance (example: 20%)
double stunChance = 0.20;

// generate random number between 0 and 1
double roll = Random.Shared.NextDouble();

// check if stun should be applied
if (roll <= stunChance)
{
// apply stun effect for 3 seconds
target.ApplyMagicEffect(
MagicEffectNumber.Stunned,
TimeSpan.FromSeconds(3));
}

ze-dom · 2026-03-27T12:42:00Z