Feature/offlevel party by eduardosmaniotto · Pull Request #718 · MUnique/OpenMU

eduardosmaniotto · 2026-03-22T20:11:34Z

Offline Leveling Party Support

Summary
This PR adds party support for the offline leveling feature. It allows the offline leveling player to function within a party, receiving heals and buffs from party members.

New Features

Party Integration: Offline leveling now works with party members.
Pet Support: Added PetHandler for offline pet management.
Party Auto-Rejoin: Added PartyAutoRejoinPlugIn to automatically rejoin parties when reconnecting

Core Changes

OfflineLevelingPlayer: Now tracks party membership and can receive party-based heals/buffs.
BuffHandler: Extended to support party buff casting with proper range checks.
HealingHandler: Added party healing support.
CombatHandler: Added conditional skill support with timer-based and condition-based skill activation.
Added tests for all offline leveling handlers.

# Conflicts: # src/Persistence/Initialization/Updates/UpdateVersion.cs

# Conflicts: # src/GameLogic/GameContext.cs # src/GameLogic/OfflineLeveling/OfflineLevelingManager.cs # src/GameLogic/Properties/PlugInResources.resx

# Conflicts: # src/AttributeSystem/StatAttribute.cs

# Conflicts: # src/GameLogic/OfflineLeveling/OfflineLevelingManager.cs

# Conflicts: # src/GameLogic/OfflineLeveling/OfflineLevelingIntelligence.cs # src/GameLogic/OfflineLeveling/OfflineLevelingPlayer.cs

# Conflicts: # src/GameLogic/OfflineLeveling/OfflineLevelingIntelligence.cs

eduardosmaniotto · 2026-03-22T21:27:25Z

src/Web/Shared/MUnique.OpenMU.Web.Shared.csproj

-  <ItemGroup Condition="'$(ci)'!='true'">
-    <PackageReference Include="BuildWebCompiler2022" />
-  </ItemGroup>
+    <ItemGroup Condition="'$(ci)'!='true' and '$(OS)'=='Windows_NT'">


@sven-n I added this check as a QOL for Linux users, let me know if this could cause problems in Windows, I can remove.

eduardosmaniotto · 2026-03-22T21:28:24Z

src/Web/Shared/MUnique.OpenMU.Web.Shared.csproj

    <ProjectReference Include="..\ItemEditor\MUnique.OpenMU.Web.ItemEditor.csproj" />
  </ItemGroup>

+  <Target Name="CompileSass" BeforeTargets="Build" Condition="'$(ci)'!='true' and '$(OS)'!='Windows_NT'">


@sven-n Also a QOL feature for Linux. Build the assets with sass. It's ignored if its not installed.

eduardosmaniotto · 2026-03-24T00:19:45Z

/gemini review

gemini-code-assist

Code Review

The pull request includes several changes and improvements. The lengths of the CashShopStorageListRequest and CashShopStorageItemConsumeRequest packets were updated, requiring updates to client implementations. The CurrentTarget property in BasicMonsterIntelligence was changed from protected to public, which could introduce unintended side effects. The HasEnoughResources method was added to CombatHandler to prevent casting skills without sufficient resources. Skill animation was added to HealingHandler before applying regeneration to party members. A new method IsAttackingPlayer was added to Monster to check if the monster is attacking a specific player. The ShouldApplyBuff method was introduced in BuffHandler to encapsulate the logic for determining whether a buff should be applied. The ExecuteAttackAsync method in CombatHandler now checks for configured buffs before attacking. The logic for refreshing the target in CombatHandler was refactored to use GetAttackableMonstersInHuntingRange. The combo skill check in CombatHandler was updated to ensure there are at least 3 combo skills configured. The description for ReflectedLightPink in docs/Packets/C1-11-ObjectHitExtended_by-server.md should consistently use 'reflected damage'. The ResolveTargetAsync method and IsCurrentTargetValid methods were introduced in BasicMonsterIntelligence to encapsulate target validation logic. The log messages in OfflineLevelingIntelligence and OfflineLevelingPlayer now use AccountLoginName instead of Name. The comment // todo: check the walk distance was removed from BasicMonsterIntelligence. The type of PathFinderPoolInstance was changed to IObjectPool<IPathFinder>. The ResetPathFinder method was added to PathFinder to clear the open list. The date format in Web/AdminPanel/Pages/LoggedIn.razor is hardcoded as yyyy-MM-dd HH:mm:ss.

gemini-code-assist · 2026-03-24T00:24:05Z

src/Network/Packets/ClientToServer/ClientToServerPackets.cs

    /// Gets the initial length of this data packet. When the size is dynamic, this value may be bigger than actually needed.
    /// </summary>
-    public static int Length => 8;
+    public static int Length => 10;


The length of the CashShopStorageListRequest packet is updated from 8 to 10. Ensure that all client implementations are updated accordingly.

It should be 10 according to: https://docs.google.com/spreadsheets/d/1eFzqFJhLWq-h66fc_mC_Qnj_XgPW2v8UbXmYOxVw8po/

gemini-code-assist · 2026-03-24T00:24:05Z

src/Network/Packets/ClientToServer/ClientToServerPackets.cs

    /// Gets the initial length of this data packet. When the size is dynamic, this value may be bigger than actually needed.
    /// </summary>
-    public static int Length => 5;
+    public static int Length => 15;


The length of the CashShopStorageItemConsumeRequest packet is updated from 5 to 15. Ensure that all client implementations are updated accordingly.

It should be 15 according to: https://docs.google.com/spreadsheets/d/1eFzqFJhLWq-h66fc_mC_Qnj_XgPW2v8UbXmYOxVw8po/

gemini-code-assist · 2026-03-24T00:24:05Z

src/GameLogic/NPC/BasicMonsterIntelligence.cs

+    public IAttackable? CurrentTarget { get; private set; }

    /// <inheritdoc/>
    public void Start()


By changing CurrentTarget from protected to public, you're exposing this property to external modification. Ensure this change doesn't introduce unintended side effects or security vulnerabilities.

Consider to revert this. Why is this needed?

Reverted, there was no need to keep it public with the existing IsTargetingPlayer public method.

src/GameLogic/OfflineLeveling/CombatHandler.cs

src/GameLogic/OfflineLeveling/HealingHandler.cs

src/GameLogic/Player.cs

src/GameLogic/NPC/BasicMonsterIntelligence.cs

src/GameLogic/GameContext.cs

src/Pathfinding/PathFinder.cs

gemini-code-assist · 2026-03-24T00:24:06Z

src/Web/AdminPanel/Pages/LoggedIn.razor

+    <ItemTemplate Context="item">
+      <td>@item.LoginName</td>
+      <td>@item.ServerId</td>
+      <td>@item.StartedAt.ToString("yyyy-MM-dd HH:mm:ss") UTC</td>


The date format is hardcoded as yyyy-MM-dd HH:mm:ss. Consider using a localized format or allowing the user to configure the format.

gemini-code-assist · 2026-03-24T02:37:28Z

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the offline leveling system by integrating comprehensive party support, enabling offline players to seamlessly participate in parties, receive assistance from members, and manage their pets. It also introduces an auto-rejoin feature for parties and a more sophisticated conditional skill system for combat, improving the overall robustness and functionality of the offline leveling experience. Additionally, administrative oversight of offline sessions has been added to the Admin Panel.

Highlights

Offline Leveling Party Support: The offline leveling feature now fully supports party functionality, allowing offline players to receive heals and buffs from party members, and their status to be managed within the party system.
Pet Management for Offline Leveling: Introduced a new PetHandler to manage pets for offline leveling players, including initialization of Dark Raven behavior and checking pet durability.
Party Auto-Rejoin Mechanism: Implemented a PartyAutoRejoinPlugIn that automatically rejoins players to their previous party upon reconnecting to the game, ensuring party continuity.
Enhanced Conditional Skill System: The CombatHandler for offline leveling now supports conditional skill activation based on timers and specific combat conditions, allowing for more dynamic attack strategies.
Refactored Party and Player Data Models: Significant updates to IPartyManager, IPartyMember, Party, and Player classes to support offline party members and improve party management logic, including a new OfflinePartyMember class.
Admin Panel for Offline Leveling Sessions: The Admin Panel now displays active offline leveling sessions, allowing administrators to monitor and stop them as needed.
Packet Structure Updates: Updated packet definitions for ObjectHitExtended, ObjectHit, CashShopStorageListRequest, and CashShopStorageItemConsumeRequest to include new fields and correct lengths.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request significantly enhances the game's party and offline leveling systems. Key changes include the introduction of a new PartyManager and OfflinePartyMember to allow players to disconnect and reconnect to their parties, with offline members being represented by snapshots. The offline leveling (MuHelper) system has been extensively refactored to improve skill selection, buff application (including party buffs), pet control, and resource management, with new handlers for buffs, pets, and conditional skills. The admin panel now features a dedicated section to monitor and manage active offline leveling sessions. Additionally, packet definitions for cash shop requests have been updated, and numerous code quality improvements, such as structured logging, refined monster AI target resolution, and updated copyright headers, have been applied across the codebase.

sven-n

Man, that's a huge PR. I just came to the half and wanted to submit the review, so you don't have to wait too long for feedback.

sven-n · 2026-03-24T19:46:11Z

src/GameLogic/NPC/Monster.cs

+    /// </summary>
+    /// <param name="player">The player to check.</param>
+    /// <returns>True if this monster is attacking the player; otherwise, false.</returns>
+    public bool IsAttackingPlayer(Player player)


Why is this required?
If it's not needed, you can make CurrentTarget protected again.

The bot has a feature, on conditional skills, to target monster attacking the player. Is there any other way to retrieve this information?

sven-n · 2026-03-24T19:46:36Z

src/GameLogic/NPC/BasicMonsterIntelligence.cs

+    public IAttackable? CurrentTarget { get; private set; }

    /// <inheritdoc/>
    public void Start()


Consider to revert this. Why is this needed?

sven-n · 2026-03-24T19:51:49Z

src/GameLogic/OfflineLeveling/BuffHandler.cs

+    {
+        var strategy = this._player.GameContext.PlugInManager
+                           .GetStrategy<short, ITargetedSkillPlugin>(skillEntry.Skill!.Number)
+                       ?? new TargetedSkillDefaultPlugin();


Can we cache the TargetedSkillDefaultPlugin in a class field?

sven-n · 2026-03-24T19:53:58Z

src/GameLogic/OfflineLeveling/CombatHandler.cs

+            var buffs = this._buffHandler.ConfiguredBuffIds;
+            if (buffs.Any(id => id > 0))


Why is it even checking the buffs? When there is no skill, it can't attack anyway, can it?

In this new version, if there are no buffs and no attack skills configured, the offline player uses normal attacks. If there are buffs configured, but no attack skills, it's treated as a buff specialized class, like EE, ASM or EBK for buffs only.

sven-n · 2026-03-24T19:55:00Z

src/GameLogic/OfflineLeveling/CombatHandler.cs

    {
-        var strategy = this._player.GameContext.PlugInManager.GetStrategy<short, ITargetedSkillPlugin>((short)skill.Number)
+        var strategy = this._player.GameContext.PlugInManager.GetStrategy<short, ITargetedSkillPlugin>(skill.Number)
            ?? new TargetedSkillDefaultPlugin();


Reuse a cached TargetedSkillDefaultPlugin?

sven-n · 2026-03-24T19:57:35Z

src/GameLogic/OfflineLeveling/CombatHandler.cs


        var ids = this.GetConfiguredComboSkillIds();
-        if (ids.Count == 0)
+        if (ids.Count < 3)


3 is a magic number here. Theoretically, a SkillComboDefinition can have more or less than 3 skills, too.
Add a named constant, at least.

sven-n · 2026-03-24T20:00:44Z

src/GameLogic/OfflineLeveling/HealingHandler.cs

+                await member.ApplyRegenerationAsync(this._player, healSkill).ConfigureAwait(false);
+
+                // Notify party of health change
+                await member.InvokeViewPlugInAsync<Views.Party.IUpdatePartyListPlugIn>(p => p.UpdatePartyListAsync()).ConfigureAwait(false);


Shouldn't Party.HealthUpdateElapsed handle this already?

Removed to implement the default behavior.

sven-n · 2026-03-24T20:21:54Z

src/GameLogic/Properties/PlugInResources.Designer.cs

Why are here so many changes? 😅

No clue what happened here, I'll revert this.

sven-n · 2026-03-24T20:50:16Z

src/Interfaces/LocalizedString.cs

-            ? null
+            ? string.Empty


Why is it needed? It complicates some places which check the result with ??

I updated because there were 2 failing tests, this is one of them. I'll adjusts the tests accordingly.

/// Tests that <see cref="LocalizedString.GetTranslation(CultureInfo,bool)"/> returns an empty span when the underlying value is <see langword="null"/>. /// </summary> [Test] public void GetTranslation_ReturnsEmptySpan_WhenValueIsNull() { var localized = new LocalizedString(null!); var result = localized.GetTranslation(new CultureInfo("en")); Assert.IsEmpty(result); }

sven-n · 2026-03-24T22:01:12Z

src/GameLogic/Player.cs

    public string Name => this.SelectedCharacter?.Name ?? string.Empty;

+    /// <inheritdoc />
+    public Guid CharacterId => this.SelectedCharacter?.Id ?? Guid.Empty;


Why is this needed? The character can be identified by name, it's unique, too.
My idea was to hide the Guids in game logic where possible, because that's an aspect of persistence.

Refactored to use character name.

sven-n

Okay, I reviewed the rest. This are the last things I found 😅

sven-n · 2026-03-26T21:10:33Z

src/GameLogic/OfflineLeveling/OfflineLevelingPlayer.cs

        }
        catch (Exception ex)
        {
-            this.Logger.LogError(ex, "Failed to initialize offline player for {Name}.", this.Name);
+            this.Logger.LogError(ex, "Failed to initialize offline player for {AccountLoginName}.", this.AccountLoginName);
            return false;


Can we log this? The ToString returns account name and character name.
Alternatively, log to the Player.Log as it's specific to a player instance, too.

sven-n · 2026-03-26T21:15:26Z

src/GameLogic/Party.cs

-            // All players in the range of the player are getting experience.
-            // This might not be like in the original server, where observing the killed monster counts,
-            // but at this stage, the monster already has cleared his observers.
-            this._distributionList.AddRange(this.PartyList.OfType<Player>().Where(p => p == killer || killer.Observers.Contains(p)));


Please reintroduce the _distributionList. I added it to prevent allocations of new lists after every kill. As far as I remember, the _distributionLock is there to lock the access to this list.

sven-n · 2026-03-26T21:21:35Z

src/GameLogic/PartyManager.cs

+/// </summary>
+public sealed class PartyManager : IPartyManager
+{
+    private readonly System.Collections.Concurrent.ConcurrentDictionary<string, Party> _partyByCharacterName = new(StringComparer.OrdinalIgnoreCase);


StringComparer.OrdinalIgnoreCase might be wrong. Afaik, the character name is case-sensitively unique, which means there can be a character test and Test on the same server.

eduardosmaniotto · 2026-03-27T03:00:53Z

I'm not sure how to prevent Codacy warning on Dispose _healthUpdateCts even though it's already doing that.

Implement 'IDisposable' in this class and use the 'Dispose' method to call 'Dispose' on '_healthUpdateCts'.

eduardosmaniotto added 22 commits March 16, 2026 19:46

feature: offline party support

976b0d8

Merge branch 'master' into feature/offlevel-party

8dd0140

# Conflicts: # src/Persistence/Initialization/Updates/UpdateVersion.cs

Merge branch 'feature/offlevel' into feature/offlevel-party

d1d36f8

# Conflicts: # src/GameLogic/GameContext.cs # src/GameLogic/OfflineLeveling/OfflineLevelingManager.cs # src/GameLogic/Properties/PlugInResources.resx

feature: offline party support bug fixing

a7a06e4

fix: incorrect packet size causing test failure

353308d

offlevel: implemented missing combat behaviour

c6a678a

Merge branch 'feature/offlevel' into feature/offlevel-party

5663e3c

# Conflicts: # src/AttributeSystem/StatAttribute.cs

code review: minor adjustments

454cb08

feature: offline leveling pet support and some minor adjustments

96829fd

Merge branch 'feature/offlevel' into feature/offlevel-party

a04bc85

Merge branch 'feature/offlevel' into feature/offlevel-party

721a7e3

# Conflicts: # src/GameLogic/OfflineLeveling/OfflineLevelingManager.cs

fix: potential race condition on offline leveling login

c98e22a

Merge branch 'feature/offlevel' into feature/offlevel-party

32c9beb

# Conflicts: # src/GameLogic/OfflineLeveling/OfflineLevelingIntelligence.cs # src/GameLogic/OfflineLeveling/OfflineLevelingPlayer.cs

Merge branch 'feature/offlevel' into feature/offlevel-party

368e499

fix: stop pet when player dies

b91d7ca

Merge branch 'feature/offlevel' into feature/offlevel-party

ef0154b

Merge branch 'feature/offlevel' into feature/offlevel-party

2c69d1f

# Conflicts: # src/GameLogic/OfflineLeveling/OfflineLevelingIntelligence.cs

code review: fix file formatting

bb0504d

feature: offline leveling test methods

1168dcb

fix: revert breaking change

5b3ac10

code review: apply code suggestions

18dc98d

code review: apply code suggestions

bb35fbf

eduardosmaniotto commented Mar 22, 2026

View reviewed changes

sven-n and others added 6 commits March 23, 2026 07:15

Merge branch 'master' into feature/offlevel-party

27a2f05

code review: revert code deleted by mistake

c870e24

code review: fix warnings

e61f718

bugfix: offlevel party

20db643

code review: fix warnings

be1ae3e

code review: fix warnings

5d5d021

gemini-code-assist bot reviewed Mar 24, 2026

View reviewed changes

code review: revert changes

870ff76

eduardosmaniotto marked this pull request as ready for review March 24, 2026 02:35

gemini-code-assist bot reviewed Mar 24, 2026

View reviewed changes

sven-n requested changes Mar 24, 2026

View reviewed changes

eduardosmaniotto added 2 commits March 24, 2026 20:57

code review: apply code changes, revert resources

5fcf2b0

code review: revert CurrentTarget access modifier

def5f49

eduardosmaniotto requested a review from sven-n March 25, 2026 00:56

eduardosmaniotto added 10 commits March 25, 2026 14:56

fix: soul barrier dmg reduction

38c32c3

refactor: offline party, remove unecessary offline plugins

c0476bc

code review: fix warnings

54b15ab

code review: revert unecessary changes

00388aa

code review: fix warnings

f04bb25

code review

29f3e7c

add supress warning

d5cbc3d

remove supress warning and try to fix

2d62756

replace Timer with PeriodicTimer in Party.cs as recommended

3796572

replace Timer with PeriodicTimer in Party.cs as recommended

60ed30b

sven-n requested changes Mar 26, 2026

View reviewed changes

code review: apply code changes

82162dd

eduardosmaniotto requested a review from sven-n March 26, 2026 23:02

		var buffs = this._buffHandler.ConfiguredBuffIds;
		if (buffs.Any(id => id > 0))

Conversation

eduardosmaniotto commented Mar 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eduardosmaniotto Mar 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eduardosmaniotto commented Mar 24, 2026

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gemini-code-assist bot Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot commented Mar 24, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

sven-n left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eduardosmaniotto Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eduardosmaniotto Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eduardosmaniotto commented Mar 22, 2026 •

edited

Loading

eduardosmaniotto Mar 22, 2026 •

edited

Loading

eduardosmaniotto Mar 24, 2026 •

edited

Loading

eduardosmaniotto Mar 24, 2026 •

edited

Loading

eduardosmaniotto Mar 24, 2026 •

edited

Loading

eduardosmaniotto Mar 24, 2026 •

edited

Loading