Restore party_mode as primary, deprecate pause_mode#1162
Merged
Conversation
- switch.py: key/translation_key/icon/capability/method calls updated to party_mode - sensor.py: party_mode_enabled key - translations/*.json: pause_mode key renamed to party_mode; en.json name set to Party mode
This reverts commit 16ccdd8.
Mirrors the rename revert in pyworxcloud. party_mode is the correct canonical name; pause_mode was introduced by mistake. - switch.py: key, translation_key, icon (party-popper), capability, and API call updated - sensor.py: party_mode_enabled key - translations/*.json: entity.switch key renamed pause_mode -> party_mode - en.json: name set to "Party mode"
MTrab
changed the title
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mirrors the rename revert in pyworxcloud.
party_modewas the correct canonical name;pause_modewas introduced by mistake and is now gone from the integration layer.Changes
The Party Mode switch entity now uses
key="party_mode",translation_key="party_mode", iconmdi:party-popper, andDeviceCapability.PARTY_MODE. The API call is updated toset_party_mode().sensor.pyreadsparty_mode_enabledfrom the schedule dict. All 16 translation files have the entity switch key renamed frompause_modetoparty_mode; the English name is set to "Party mode".Testing
Notes
Semver proposal: patch — purely cosmetic rename revert with no functional behaviour change.