Repository navigation
fix: move prewarm_migration_speed to after restore (#78) - #79
Merged
Merged
Conversation
#78) 起動時の prewarm NFS I/O が explicit checkpoint と競合し open() レイテンシが ~0.2s に跳ね上がる問題を修正。prewarm を load_checkpoint() 完了後に移動する ことで、NFS I/O 競合を排除し定常状態での計測を保証する。 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…FF 時も対応 load_checkpoint() の責務を復元のみに戻し、prewarm_migration_speed() の呼び出しを kernel.py __init__ の restore 処理直後に配置。restore OFF 時は起動直後に計測する ため、どちらの構成でも checkpoint クリティカルパス外で計測が完了する。 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prewarm_migration_speedの呼び出しをElasticKernel.__init__（起動直後）からElasticNotebook.load_checkpoint()完了後に移動open()と競合し ~0.2s のレイテンシ増加を引き起こす問題を解消 (issue prewarm_migration_speed の NFS I/O が外部の checkpoint と競合する #78)Changes
elastic_kernel/kernel.py:__init__からprewarm_migration_speed()呼び出しを削除elastic_notebook/elastic_notebook.py:load_checkpoint()末尾でprewarm_migration_speed()をバックグラウンド実行Test plan
uv run pytest tests/ -x -q— 108 passed, 5 skippedCloses #78
🤖 Generated with Claude Code