Repository navigation
docs: fix misleading min-cut comment in optimizer_exact - #51
Merged
Merged
Conversation
The comment claimed Ford-Fulkerson, but the code actually uses shortest_augmenting_path as the flow_func. Align the comment with the implementation. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
optimizer_exact.pyの min-cut 計算箇所のコメントが実装と食い違っていたため修正します。Solve min-cut with Ford-Fulkerson.flow_func=shortest_augmenting_path(L8 で import)実際には Ford-Fulkerson ではなく
shortest_augmenting_pathを使っているため、コメントを実装に合わせました。背景(#22 の調査結果)
#22「min-cut アルゴリズムを Edmonds-Karp → Ford-Fulkerson に変えるとどうなるか」の調査で、以下が判明しました。
np.infエッジでは終了保証がなく遅化リスクがあり、そもそも networkx にford_fulkersonは存在しない(削除済み)。よって実装の変更はせず、この PR では誤ったコメントの修正のみを行います。
Close #22
🤖 Generated with Claude Code