Repository navigation
Conversation
Super-linter summary
All files and directories linted successfully For more information, see the GitHub Actions workflow run Powered by Super-linter |
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
A few issues in the updated workflow/report code (misleading consensus file extension, doc path mismatch, unused sample-sheet read, and lingering rowwise grouping) should be fixed to avoid confusion and potential downstream problems.
Review effort: Lite
Findings: 2
Open (4)
What changed in this PR
This PR improves the “consensus variants” diagnostic output used by the report by capturing bcftools isec metadata and expanding the consensus presence/absence encoding into a more user-friendly table (with per-sample columns and variant annotations), addressing the sample-order mismatch described in #51 and the poor formatting in #48.
Changes:
- Update the bcftools intersection rule to use
bcftools isec -poutput directory artifacts (includingREADME.txt) and wire them into the report inputs. - Extend the R Markdown report to parse the consensus index, expand the appearance bitstring into named sample columns, annotate variants, and export a TSV alongside the HTML report.
- Minor refactors in
report.Rmd(chunk options placement, formatting, and join scope tightening).
| File | Description |
|---|---|
| workflow/rules/report.smk | Switch intersection output handling to directory-based isec outputs and pass README.txt into the report step. |
| workflow/notebooks/report.Rmd | Build a richer consensus variant table (sample-named columns + annotations) and write it as a TSV diagnostic output. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.


Uh oh!
There was an error while loading. Please reload this page.