Skip to content

fix: fastplong wired in workflow and expose tool args - #47

Merged
rabioinf merged 3 commits into
mainfrom
dev
Oct 3, 2026
Merged

rabioinf merged 3 commits into
mainfrom
dev

Conversation

@m-jahn

@m-jahn m-jahn commented Oct 2, 2026

Copy link
Copy Markdown
Member

closes #46

@github-actions

github-actions Bot commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Super-linter summary

Language Validation result
SNAKEMAKE_SNAKEFMT Pass ✅
YAML_PRETTIER Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

@m-jahn
m-jahn requested review from rabioinf and a lite review from Copilot October 2, 2026 08:53

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

STAR alignment input expansion currently enumerates all samples (breaking per-sample execution), and the new plotCoverage config access can raise KeyError with valid configs unless a safe default/requirement is enforced.

Review effort: Lite
Findings: 1 High severity · 1 Medium severity · 1 Low severity

Open (3)
What changed in this PR

This PR wires the selected read-processing tool (e.g., fastp vs fastplong) into downstream mapping rules by parameterizing input paths, and exposes DeepTools plotCoverage extra arguments via config (closing #46).

Changes:

  • Update aligner rules (STAR/minimap2/bwa-mem2/bowtie2) to read processed FASTQs from results/{processing_tool}/... based on config["processing"]["tool"].
  • Expose deeptools_plotcoverage extra CLI args via config + schema, and set defaults in example configs.
  • Add workflow-time guardrails/warnings for unsupported tool/input combinations (fastplong + paired-end, minimap2 + paired-end warning).
File Description
workflow/​rules/​star.smk Switch STAR inputs to use the configured processing tool output directory.
workflow/​rules/​minimap2.smk Parameterize minimap2 query FASTQ paths by processing tool.
workflow/​rules/​bwamem2.smk Parameterize bwa-mem2 read FASTQ paths by processing tool.
workflow/​rules/​bowtie2.smk Parameterize bowtie2 read FASTQ paths by processing tool.
workflow/​rules/​common.smk Update MultiQC inputs for processing JSONs; add fastplong/minimap2 paired-end guardrails.
workflow/​rules/​mapping_stats.smk Read plotCoverage extra args from config instead of hardcoding.
config/​schemas/​config.schema.yml Add schema default for deeptools_plotcoverage.extra.
config/​config.yml Set default deeptools_plotcoverage.extra in example config.
.test/​config/​config.yml Mirror the default deeptools_plotcoverage.extra in test config.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread workflow/rules/star.smk
Comment thread workflow/rules/mapping_stats.smk
Comment thread workflow/rules/common.smk
Comment thread workflow/rules/common.smk

@rabioinf rabioinf left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my comment

@rabioinf rabioinf left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good now

@rabioinf
rabioinf merged commit 02e89f7 into main Oct 3, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fastplong is not wired into the workflow

3 participants