Repository navigation
Conversation
Super-linter summary
All files and directories linted successfully For more information, see the GitHub Actions workflow run Powered by Super-linter |
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
STAR alignment input expansion currently enumerates all samples (breaking per-sample execution), and the new plotCoverage config access can raise KeyError with valid configs unless a safe default/requirement is enforced.
Review effort: Lite
Findings: 1
Open (3)
What changed in this PR
This PR wires the selected read-processing tool (e.g., fastp vs fastplong) into downstream mapping rules by parameterizing input paths, and exposes DeepTools plotCoverage extra arguments via config (closing #46).
Changes:
- Update aligner rules (STAR/minimap2/bwa-mem2/bowtie2) to read processed FASTQs from
results/{processing_tool}/...based onconfig["processing"]["tool"]. - Expose
deeptools_plotcoverageextra CLI args via config + schema, and set defaults in example configs. - Add workflow-time guardrails/warnings for unsupported tool/input combinations (fastplong + paired-end, minimap2 + paired-end warning).
| File | Description |
|---|---|
| workflow/rules/star.smk | Switch STAR inputs to use the configured processing tool output directory. |
| workflow/rules/minimap2.smk | Parameterize minimap2 query FASTQ paths by processing tool. |
| workflow/rules/bwamem2.smk | Parameterize bwa-mem2 read FASTQ paths by processing tool. |
| workflow/rules/bowtie2.smk | Parameterize bowtie2 read FASTQ paths by processing tool. |
| workflow/rules/common.smk | Update MultiQC inputs for processing JSONs; add fastplong/minimap2 paired-end guardrails. |
| workflow/rules/mapping_stats.smk | Read plotCoverage extra args from config instead of hardcoding. |
| config/schemas/config.schema.yml | Add schema default for deeptools_plotcoverage.extra. |
| config/config.yml | Set default deeptools_plotcoverage.extra in example config. |
| .test/config/config.yml | Mirror the default deeptools_plotcoverage.extra in test config. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.



closes #46