Skip to content

ci(archive): keep a human as the only approver; the bot only opens an issue - #21

Merged
RiccardoBiosas merged 1 commit into
mainfrom
ci/archive-human-review
Oct 15, 2026
Merged

RiccardoBiosas merged 1 commit into
mainfrom
ci/archive-human-review

Conversation

@RiccardoBiosas

Copy link
Copy Markdown
Contributor

The weekly archive job pushed a bot branch and opened a PR. That required the repo setting "Allow GitHub Actions to create and approve pull requests", which would also let any workflow token approve PRs. Bot-opened PRs would not run CI either, since events from the built-in token start no workflows. The job now runs with contents: read and issues: write only. It runs the archiver in report mode, which still triggers Wayback's Save Page Now, so the slow snapshotting happens in CI. It then opens or updates one archive-labelled issue listing the snapshots found and the failures, with the local commands to add them; the issue closes itself once every source has a snapshot. A maintainer runs npm run archive -- --write, reviews, commits, opens the PR and merges. CONTRIBUTING and CHANGELOG [Unreleased] are updated.

What

Checklist (Definition of done)

  • npm test passes locally (validate + build, dist/ rebuilt and committed)
  • Every changed record has ≥1 source with a working URL (npm run linkcheck)
  • status / confidence honestly reflect the sourcing (no upgrade beyond sources)
  • All enum values and mappings IDs exist exactly as published — nothing invented
  • id is new and permanent (no rename/recycle of existing ids)
  • No exploit code, payloads, prompts, or step-by-step offensive detail
  • Victim orgs named only where a public/first-party disclosure already named them
  • Schema changed? README, taxonomy files, and CITATION.cff updated accordingly

… issue

The weekly archive job pushed a bot branch and opened a PR. That required
the repo setting "Allow GitHub Actions to create and approve pull requests",
which would also let any workflow token approve PRs. Bot-opened PRs would
not run CI either, since events from the built-in token start no workflows.
The job now runs with contents: read and issues: write only. It runs the
archiver in report mode, which still triggers Wayback's Save Page Now, so
the slow snapshotting happens in CI. It then opens or updates one
archive-labelled issue listing the snapshots found and the failures, with
the local commands to add them; the issue closes itself once every source
has a snapshot. A maintainer runs npm run archive -- --write, reviews,
commits, opens the PR and merges. CONTRIBUTING and CHANGELOG [Unreleased]
are updated.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@RiccardoBiosas
RiccardoBiosas merged commit 6af7a63 into main Oct 15, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant