Skip to content

Conversation

@JPrevost
Copy link
Member

https://mitlibraries.atlassian.net/browse/USE-333

Developer

Accessibility
  • ANDI or WAVE has been run in accordance to our guide.
  • This PR contains no changes to the view layer.
  • New issues flagged by ANDI or WAVE have been resolved.
  • New issues flagged by ANDI or WAVE have been ticketed (link in the Pull Request details above).
  • No new accessibility issues have been flagged.
New ENV
  • All new ENV is documented in README.
  • All new ENV has been added to Heroku Pipeline, Staging and Prod.
  • ENV has not changed.
Approval beyond code review
  • UXWS/stakeholder approval has been confirmed.
  • UXWS/stakeholder review will be completed retroactively.
  • UXWS/stakeholder review is not needed.
Additional context needed to review

E.g., if the PR includes updated dependencies and/or data
migration, or how to confirm the feature is working.

Code Reviewer

Code
  • I have confirmed that the code works as intended.
  • Any CodeClimate issues have been fixed or confirmed as
    added technical debt.
Documentation
  • The commit message is clear and follows our guidelines
    (not just this pull request message).
  • The documentation has been updated or is unnecessary.
  • New dependencies are appropriate or there were no changes.
Testing
  • There are appropriate tests covering any new functionality.
  • No additional test coverage is required.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 21067884894

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 98.014%

Totals Coverage Status
Change from base Build 21067762146: 0.003%
Covered Lines: 1234
Relevant Lines: 1259

💛 - Coveralls

@mitlib mitlib temporarily deployed to timdex-ui-pi-use-333-li-4u9zp7 January 16, 2026 13:19 Inactive
@matt-bernhardt matt-bernhardt self-assigned this Jan 16, 2026
Copy link
Member

@matt-bernhardt matt-bernhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to get more familiar with the testing pattern used here, but I see it passes, and I follow enough of the logic to approve it. The change to the model itself is straightforward enough.

@JPrevost JPrevost merged commit 0d00c79 into main Jan 16, 2026
5 checks passed
@JPrevost JPrevost deleted the use-333-libkey-404 branch January 16, 2026 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants