Outs checkin bug fix

mittab/apps/tab/forms.py

@@ -62,7 +62,7 @@ def __init__(self, *args, **kwargs):
     def save(self, commit=True):
         room = super(RoomForm, self).save(commit)
         num_rounds = TabSettings.objects.get(key="tot_rounds").value
-        for i in range(num_rounds):
+        for i in range(-1, num_rounds):
             field_name = f"checkin_{i}"
             if field_name in self.cleaned_data:
                 should_be_checked_in = self.cleaned_data[field_name]

mittab/libs/tests/views/test_tab_views.py

@@ -8,6 +8,7 @@
 
 from mittab.apps.tab.models import (
     Room,
+    RoomCheckIn,
     TabSettings,
     Team,
     Round,
@@ -172,6 +173,28 @@ def test_manual_judge_indicator_removed_after_unassign(self):
             ManualJudgeAssignment.objects.filter(round=round_obj, judge=judge).exists()
         )
 
+    def test_view_room_saves_outround_checkin(self):
+        room = Room.objects.first()
+        url = reverse("view_room", args=[room.pk])
+        post_data = {
+            "name": room.name,
+            "rank": room.rank,
+            "checkin_-1": "on",
+        }
+
+        response = self.client.post(url, data=post_data)
+        self.assertEqual(response.status_code, 302)
+        self.assertTrue(
+            RoomCheckIn.objects.filter(room=room, round_number=0).exists()
+        )
+
+        post_data.pop("checkin_-1")
+        response = self.client.post(url, data=post_data)
+        self.assertEqual(response.status_code, 302)
+        self.assertFalse(
+            RoomCheckIn.objects.filter(room=room, round_number=0).exists()
+        )
+
     def _round_card_html(self, response, round_id):
         content = response.content.decode()
         match = re.search(