Open
Conversation
gtrevisan
reviewed
Apr 2, 2026
|
|
||
| @staticmethod | ||
| @physics_method( | ||
| columns=["nl_ts1", "nl_ts2", "nl_tci1", "nl_tci2"], |
Member
There was a problem hiding this comment.
@yumouwei is this the best we can do in terms of naming these new features?
| nl_tci1, nl_tci2 : TCI line-integrated density at YAG 1 and 2 timestamps [m^-2] | ||
| """ | ||
| nl_ts1, nl_ts2, nl_tci1, nl_tci2, time1, time2 = ( | ||
| CmodThomsonDensityMeasure.compare_ts_tci(params) |
Member
There was a problem hiding this comment.
it's not clear to me -- what's the relationship between this new physics method and the pre-existing get_peaking_factors for C-MOD with a use_ts_tci_calibration = True?
Contributor
Author
There was a problem hiding this comment.
This physics method actually returns the measured densities from the TCI, whereas the get_peaking_factors method would use them to adjust the TS measurements before discarding them.
| indices2 = indices1 + 1 | ||
| else: | ||
| indices1 = 2 * np.arange(nyag1) + (nyag1 > nyag2) | ||
| elif nyag1 < nyag2: |
Member
gtrevisan
reviewed
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two-Color Interferometry can be used to calibrate measurements from Thomson scattering. For a while it has been hardcoded to not do this, and as such the TCI-related methods have gone untested and are broken. This PR fixes some obvious errors so the methods can run to completion, but I'm not sure about functional correctness. The results are similar enough to other density measurements, but these methods should be vetted more thoroughly at some point.