Fix for pandas 3.0 #561
Merged
Fix for pandas 3.0 #561
+5
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Locally |
tompollard
requested changes
Jan 23, 2026
Member
tompollard
left a comment
tompollard
left a comment
There was a problem hiding this comment.
thanks @larsoner, please could you remove the print statement?
larsoner
commented
Jan 23, 2026
Contributor
Author
|
Done @tompollard ! |
|
Can we merge and release this PR @tompollard ? It is blocking braindecode and eegdash >.< |
Member
|
Thanks everyone! The fix is now available in the latest release on PyPI (v4.3.1): https://pypi.org/project/wfdb/ |
|
Many thanks 🙏 @tompollard |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A minimal fix to get
import wfdbworking again with pandas 3.0+. Not sure if others are required. Happy to iterate further with tests etc. as needed, or close if someone else is already working on a fix!Closes #560