Skip to content

fix: use globs instead of ls in make_concepts.sh#2089

Open
Chessing234 wants to merge 1 commit into
MIT-LCP:mainfrom
Chessing234:fix/make-concepts-glob
Open

fix: use globs instead of ls in make_concepts.sh#2089
Chessing234 wants to merge 1 commit into
MIT-LCP:mainfrom
Chessing234:fix/make-concepts-glob

Conversation

@Chessing234

@Chessing234 Chessing234 commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

Summary

  • replace ls $d with "$d"/*.sql so filenames with spaces don't break
  • quote destination table and sql file paths on bq query redirects

Test plan

  • bash -n mimic-iv/concepts/make_concepts.sh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant