Skip to content

fix: [circl_passivessl] don't fail the whole expansion when a certificate can't be fetched #909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ikrksglobal wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: [circl_passivessl] don't fail the whole expansion when a certificate can't be fetched #909

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions misp_modules/modules/expansion/circl_passivessl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,12 +83,20 @@ def parse(self):
def _handle_certificate(self, certificate, ip_uuid):
x509 = MISPObject("x509")
x509.add_attribute(self.cert_hash, type=self.cert_hash, value=certificate)
cert_details = self.pssl.fetch_cert(certificate)
info = cert_details["info"]
# A certificate listed for an IP is not always fetchable: the API answers
# "Not existing certificate" or a bare 500. Keep the fingerprint and move on
# instead of failing the whole expansion.
try:
info = self.pssl.fetch_cert(certificate).get("info") or {}
except Exception:
info = {}
for feature, mapping in self.mapping.items():
if info.get(feature) is None:
continue
attribute_type, object_relation = mapping
x509.add_attribute(object_relation, type=attribute_type, value=info[feature])
x509.add_attribute(self.cert_type, type="text", value=self.cert_type)
if info:
x509.add_attribute(self.cert_type, type="text", value=self.cert_type)
x509.add_reference(ip_uuid, "seen-by")
self.misp_event.add_object(**x509)

Expand Down
Loading