Skip to content

fix: block distribution fields on default galaxy clusters#1459

Merged
Rafiot merged 1 commit into
MISP:mainfrom
nightcityblade:fix/issue-1458
Jul 24, 2026
Merged

fix: block distribution fields on default galaxy clusters#1459
Rafiot merged 1 commit into
MISP:mainfrom
nightcityblade:fix/issue-1458

Conversation

@nightcityblade

Copy link
Copy Markdown

Summary

  • fix the default galaxy cluster blocked-field list so distribution and sharing_group_id are checked separately
  • add regression coverage for both blocked fields
  • keep the existing galaxy fixture valid by marking its distributed cluster as non-default

Fixes #1458

Testing

  • .venv/bin/python -m pytest -q tests/test_galaxy_cluster.py tests/test_mispevent.py (37 passed, 2 skipped, 2 subtests passed)
  • .venv/bin/pre-commit run --files pymisp/mispevent.py tests/test_galaxy_cluster.py tests/mispevent_testfiles/galaxy.json
  • .venv/bin/mypy pymisp/mispevent.py tests/test_galaxy_cluster.py

@Rafiot

Rafiot commented Jul 24, 2026

Copy link
Copy Markdown
Member

Looks good, thanks!

@Rafiot
Rafiot merged commit 6338dd6 into MISP:main Jul 24, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Typo in MISPGalaxyCluster.from_dict prevents field blocklist from being checked

2 participants