rule conflict fetection#408
Merged
mijinummi merged 1 commit intoMay 27, 2026
Merged
Conversation
|
@Nabeelahh Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #280
Summary
Implements a conflict detection engine that identifies when multiple rules suggest contradictory fixes for the same code location, preventing confusing or erroneous auto-applied changes.
Problem
Rules may suggest contradictory fixes (e.g., one rule recommends adding a semicolon while another recommends removing it, or conflicting indentation styles). Without detection, users could receive conflicting guidance or the system might apply changes that cancel each other out.
Changes
src/analysis/conflicts/module with conflict detection logicImplementation Scope
New Files:
src/analysis/conflicts/detector.ts- Core conflict detection logicsrc/analysis/conflicts/types.ts- Type definitions for conflictssrc/analysis/conflicts/warning.ts- User warning systemsrc/analysis/conflicts/index.ts- Public module interfaceRequirements Checklist
Acceptance Criteria
Testing Notes