Skip to content

rule conflict fetection#408

Merged
mijinummi merged 1 commit into
MDTechLabs:mainfrom
Nabeelahh:feat/Rule-conflict-detection
May 27, 2026
Merged

rule conflict fetection#408
mijinummi merged 1 commit into
MDTechLabs:mainfrom
Nabeelahh:feat/Rule-conflict-detection

Conversation

@Nabeelahh
Copy link
Copy Markdown
Contributor

closes #280

Summary

Implements a conflict detection engine that identifies when multiple rules suggest contradictory fixes for the same code location, preventing confusing or erroneous auto-applied changes.

Problem

Rules may suggest contradictory fixes (e.g., one rule recommends adding a semicolon while another recommends removing it, or conflicting indentation styles). Without detection, users could receive conflicting guidance or the system might apply changes that cancel each other out.

Changes

  • Added src/analysis/conflicts/ module with conflict detection logic
  • Implemented rule suggestion comparison algorithm
  • Added warning system for users when conflicts are detected
  • Integrated conflict detection into the analysis pipeline

Implementation Scope

New Files:

  • src/analysis/conflicts/detector.ts - Core conflict detection logic
  • src/analysis/conflicts/types.ts - Type definitions for conflicts
  • src/analysis/conflicts/warning.ts - User warning system
  • src/analysis/conflicts/index.ts - Public module interface

Requirements Checklist

  • ✅ Identify conflicts between rule suggestions
  • ✅ Warn users when conflicts are detected

Acceptance Criteria

  • ✅ Conflicts detected across all supported rule types

Testing Notes

  • Test overlapping rule ranges
  • Test partial vs. exact match conflicts
  • Test no-conflict scenarios
  • Verify warning appears only for true contradictions

@drips-wave
Copy link
Copy Markdown

drips-wave Bot commented May 27, 2026

@Nabeelahh Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@mijinummi mijinummi merged commit 2fcf410 into MDTechLabs:main May 27, 2026
0 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🔄 Rule Conflict Detection

2 participants