minima-ws: enable reactor-thread short-circuit (RCA fast path)#823
Merged
Conversation
…path) minima-ws vendored Minima's Reactor.cs with the inline fast paths in EnqueueReturnQ / EnqueueFlush / EnqueueRecycle commented out, so buffer return / flush / recycle went through the cross-thread MPSC queue + eventfd wake. With RCA=false the handler resumes inline on the reactor thread, so those callers are already on the reactor thread and can return the buffer, submit the send, or recycle directly on the ring. Uncomment the three fast paths to match the current Minima engine.
Owner
Author
|
/benchmark -f minima-ws --save |
Contributor
|
👋 |
Contributor
Benchmark ResultsFramework:
Full log |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
minima-ws(merged in #816) vendored Minima'sReactor.cswith the inline fast paths inEnqueueReturnQ/EnqueueFlush/EnqueueRecyclecommented out — so every buffer return / flush / recycle went through the cross-thread MPSC queue + aneventfdwake.Since minima-ws runs with
RunContinuationsAsynchronously = false, the handler resumes inline on the reactor thread. That means the caller ofEnqueue{Return,Flush,Recycle}is already the reactor thread, so it can hit the ring directly (ReturnBufferDirect/SubmitSend/Recycle) instead of enqueuing + waking. This uncomments the three fast paths to match the current Minima engine (and the newminimaH1 entry).Pure perf fix — 6 lines, no behavior change for the WS echo contract. Builds clean.